Attachment 342191 Details for Bug 186386 – patch

[patch] patch

c-backup.diff (text/plain), 1.61 KB, created by Saam Barati on 2018-06-07 11:09:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-06-07 11:09:26 PDT

Size: 1.61 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232587)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-06-07  Saam Barati  <sbarati@apple.com>
>+
>+        TierUpCheckInjectionPhase systematically never puts the outer-most loop in an inner loop's vector of outer loops
>+        https://bugs.webkit.org/show_bug.cgi?id=186386
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This looks like an 8% speedup on Kraken's imaging-gaussian-blur subtest.
>+
>+        * dfg/DFGTierUpCheckInjectionPhase.cpp:
>+        (JSC::DFG::TierUpCheckInjectionPhase::run):
>+
> 2018-06-07  Saam Barati  <sbarati@apple.com>
> 
>         Make DFG to FTL OSR entry code more sane by removing bad RELEASE_ASSERTS and making it trigger compiles in outer loops before inner ones
>Index: Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp	(revision 232587)
>+++ Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp	(working copy)
>@@ -122,8 +122,7 @@ public:
>                         if (it != naturalLoopToLoopHint.end())
>                             descriptor.osrEntryCandidates.append(it->value);
>                     }
>-                    if (!descriptor.osrEntryCandidates.isEmpty())
>-                        tierUpHierarchy.add(bytecodeIndex, WTFMove(descriptor));
>+                    tierUpHierarchy.add(bytecodeIndex, WTFMove(descriptor));
>                 }
>                 break;
>             }

Actions: View | Formatted Diff | Diff

Attachments on bug 186386: 342138 | 342191