Attachment 342128 Details for Bug 186385 – Fix an incorrect cast

[patch] Fix an incorrect cast

file_186385.txt (text/plain), 1.48 KB, created by mitz on 2018-06-06 23:43:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-06-06 23:43:40 PDT

Size: 1.48 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232574)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-06-06  Dan Bernstein  <mitz@apple.com>
>+
>+        REGRESSION (r232520): Crash under IPC::ArgumentCoder<WebCore::Credential>::encodePlatformData
>+        https://bugs.webkit.org/show_bug.cgi?id=186385
>+        <rdar://problem/40853796>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/mac/WebCoreArgumentCodersMac.mm:
>+        (IPC::ArgumentCoder<Credential>::encodePlatformData): Fixed an incorrect cast.
>+
> 2018-06-06  Per Arne Vollan  <pvollan@apple.com>
> 
>         Crash in lambda function WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback
>Index: Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm
>===================================================================
>--- Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm	(revision 232573)
>+++ Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm	(working copy)
>@@ -479,7 +479,7 @@ void ArgumentCoder<Credential>::encodePl
> 
>     auto archiver = secureArchiver();
>     [archiver encodeObject:nsCredential forKey:@"credential"];
>-    IPC::encode(encoder, (__bridge CFArrayRef)archiver.get().encodedData);
>+    IPC::encode(encoder, (__bridge CFDataRef)archiver.get().encodedData);
> }
> 
> bool ArgumentCoder<Credential>::decodePlatformData(Decoder& decoder, Credential& credential)

Flags:

dbates: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186385: 342128