WebKit Bugzilla
Attachment 342121 Details for
Bug 186382
: [GTK] Crash running run-webkit-tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186382-20180607021349.patch (text/plain), 1.90 KB, created by
Carlos Bentzen
on 2018-06-06 22:11:47 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Carlos Bentzen
Created:
2018-06-06 22:11:47 PDT
Size:
1.90 KB
patch
obsolete
>Subversion Revision: 232430 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index dc54d31175c09f67b41b677358dd1176ce40bd6c..97f84a97ad20f0e610cd74dc14352a4ea683e138 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,19 @@ >+2018-06-06 Carlos Eduardo Ramalho <cadubentzen@gmail.com> >+ >+ [GTK] Crash running run-webkit-tests >+ https://bugs.webkit.org/show_bug.cgi?id=186382 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Currently launchOptions.processType is not initialized in ChildProcessProxy::getLaunchOptions() >+ when coming from PluginProcessProxy. This leads to SIGSEGV because it ends up calling getenv(nullptr). >+ We need to call platformGetLaunchOptions() before ChildProcessProxy::getLaunchOptions() >+ in PluginProcessProxy::getLaunchOptions() to set launchOptions.processType to either >+ ProcessLauncher::ProcessType::Plugin64 or ProcessLauncher::ProcessType::Plugin32. >+ >+ * UIProcess/Plugins/PluginProcessProxy.cpp: >+ (WebKit::PluginProcessProxy::getLaunchOptions): >+ > 2018-06-01 Jeremy Jones <jeremyj@apple.com> > > Keyboard focus should exit fullscreen. >diff --git a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp >index 7a39f5b1aea9336d42a5cf215b10ed6c92335e44..326ae2a749e9047f6c0944e2c0640bd73c48f73d 100644 >--- a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp >+++ b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp >@@ -88,8 +88,8 @@ PluginProcessProxy::~PluginProcessProxy() > > void PluginProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions) > { >- ChildProcessProxy::getLaunchOptions(launchOptions); > platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes); >+ ChildProcessProxy::getLaunchOptions(launchOptions); > } > > void PluginProcessProxy::processWillShutDown(IPC::Connection& connection)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186382
:
342121