Attachment 342109 Details for Bug 186380 – Use the Legacy Build System in the workspace and in command-line builds

[patch] Use the Legacy Build System in the workspace and in command-line builds

file_186380.txt (text/plain), 2.42 KB, created by mitz on 2018-06-06 20:05:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-06-06 20:05:53 PDT

Size: 2.42 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 232488)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-06-06  Dan Bernstein  <mitz@apple.com>
>+
>+        [Xcode] Opt out of the New Build System
>+        https://bugs.webkit.org/show_bug.cgi?id=186380
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Use the Legacy Build System.
>+
> 2018-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.3 release.
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 232568)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-06-06  Dan Bernstein  <mitz@apple.com>
>+
>+        [Xcode] Opt out of the New Build System
>+        https://bugs.webkit.org/show_bug.cgi?id=186380
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitdirs.pm:
>+        (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
>+
> 2018-06-06  Antoine Quint  <graouts@apple.com>
> 
>         Rename color-filter to -apple-color-filter and do not expose it to Web content
>Index: Tools/Scripts/webkitdirs.pm
>===================================================================
>--- Tools/Scripts/webkitdirs.pm	(revision 232488)
>+++ Tools/Scripts/webkitdirs.pm	(working copy)
>@@ -850,6 +850,7 @@ sub XcodeOptions
>     determineXcodeSDK();
> 
>     my @options;
>+    push @options, "-UseNewBuildSystem=NO";
>     push @options, "-UseSanitizedBuildSystemEnvironment=YES";
>     push @options, ("-configuration", $configuration);
>     push @options, ("-xcconfig", sourceDir() . "/Tools/asan/asan.xcconfig", "ASAN_IGNORE=" . sourceDir() . "/Tools/asan/webkit-asan-ignore.txt") if $asanIsEnabled;
>Index: WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
>===================================================================
>--- WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings	(revision 232488)
>+++ WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings	(working copy)
>@@ -2,6 +2,8 @@
> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
> <plist version="1.0">
> <dict>
>+	<key>BuildSystemType</key>
>+	<string>Original</string>
> 	<key>IDEWorkspaceSharedSettings_AutocreateContextsIfNeeded</key>
> 	<false/>
> </dict>

Actions: View | Formatted Diff | Diff

Attachments on bug 186380: 342109