Attachment 342068 Details for Bug 186358 – Patch

[patch] Patch

bug-186358-20180606115044.patch (text/plain), 2.71 KB, created by Brent Fulgham on 2018-06-06 11:50:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-06-06 11:50:45 PDT

Size: 2.71 KB

patch

obsolete

>Subversion Revision: 232549
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 9b2ece8e41ed6a545ca940a6557584c25a5b5db7..c7d9eb82082f89e4b202760edb7fc5efa683c566 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-06  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Remove unused debug mode conditions
>+        https://bugs.webkit.org/show_bug.cgi?id=186358
>+        <rdar://problem/39117121>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove some unused code paths related to ResourceLoadStatistics debug mode.
>+
>+        * UIProcess/WebResourceLoadStatisticsStore.cpp:
>+        (WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
>+        (WebKit::WebResourceLoadStatisticsStore::shouldPartitionCookies const):
>+
> 2018-06-06  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION (r232301) - Unable to enter video fullscreen
>diff --git a/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp b/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
>index 3e78315ac79bae823ef117bbb7ec767ea8b10d5b..5382a55610f730c4f85be88a67a2d556df70f588 100644
>--- a/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
>+++ b/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp
>@@ -556,12 +556,8 @@ void WebResourceLoadStatisticsStore::logUserInteraction(const URL& url)
>         statistics.hadUserInteraction = true;
>         statistics.mostRecentUserInteractionTime = WallTime::now();
> 
>-        if (m_debugModeEnabled) {
>-            if (statistics.isMarkedForCookieBlocking)
>-                updateCookiePartitioningForDomains({ primaryDomain }, { }, { }, ShouldClearFirst::No, []() { });
>-        } else
>-            if (statistics.isMarkedForCookiePartitioning || statistics.isMarkedForCookieBlocking)
>-                updateCookiePartitioningForDomains({ }, { }, { primaryDomain }, ShouldClearFirst::No, []() { });
>+        if (statistics.isMarkedForCookieBlocking)
>+            updateCookiePartitioningForDomains({ primaryDomain }, { }, { }, ShouldClearFirst::No, []() { });
>     });
> }
> 
>@@ -1057,10 +1053,7 @@ void WebResourceLoadStatisticsStore::mergeStatistics(Vector<ResourceLoadStatisti
> 
> bool WebResourceLoadStatisticsStore::shouldPartitionCookies(const ResourceLoadStatistics& statistic) const
> {
>-    if (m_debugModeEnabled)
>-        return statistic.isPrevalentResource && statistic.hadUserInteraction;
>-
>-    return statistic.isPrevalentResource && statistic.hadUserInteraction && WallTime::now() > statistic.mostRecentUserInteractionTime + m_parameters.timeToLiveCookiePartitionFree;
>+    return statistic.isPrevalentResource && statistic.hadUserInteraction;
> }
> 
> bool WebResourceLoadStatisticsStore::shouldBlockCookies(const ResourceLoadStatistics& statistic) const

Actions: View | Formatted Diff | Diff

Attachments on bug 186358: 342068 | 342079 | 342086 | 342098