Attachment 342062 Details for Bug 186357 – Patch

[patch] Patch

bug-186357-20180606104806.patch (text/plain), 1.82 KB, created by Jer Noble on 2018-06-06 10:48:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-06-06 10:48:08 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 232541
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5a34b649be798156a6b89a2af206da4faa21d8ee..470df4f2bde6182d94709ba8d1f0297fbe6c30d4 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-06  Jer Noble  <jer.noble@apple.com>
>+
>+        REGRESSION (r232301) - Unable to enter video fullscreen
>+        https://bugs.webkit.org/show_bug.cgi?id=186357
>+        <rdar://problem/40838449>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Only set up the standby fullscreen element if we are in element fullscreen.
>+
>+        * WebProcess/FullScreen/WebFullScreenManager.cpp:
>+        (WebKit::WebFullScreenManager::videoControlsManagerDidChange):
>+
> 2018-05-29  Jer Noble  <jer.noble@apple.com>
> 
>         Auto-pip should use main content heuristic.
>diff --git a/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp b/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>index 3bff5a439128cced55c894e924ca9ed6d4e8151b..11f5790e95c8ddc8df7ed412c8a0b04a5246036c 100644
>--- a/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>+++ b/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
>@@ -89,7 +89,12 @@ void WebFullScreenManager::videoControlsManagerDidChange()
> {
> #if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
>     auto* currentPlaybackControlsElement = m_page->playbackSessionManager().currentPlaybackControlsElement();
>-    setPIPStandbyElement(is<HTMLVideoElement>(currentPlaybackControlsElement) ? downcast<HTMLVideoElement>(currentPlaybackControlsElement) : nullptr);
>+    if (!m_element || !is<HTMLVideoElement>(currentPlaybackControlsElement)) {
>+        setPIPStandbyElement(nullptr);
>+        return;
>+    }
>+
>+    setPIPStandbyElement(downcast<HTMLVideoElement>(currentPlaybackControlsElement));
> #endif
> }
>

Flags:

jonlee: review+
jer.noble: commit-queue+

Actions: View | Formatted Diff | Diff

Attachments on bug 186357: 342062