Attachment 342048 Details for Bug 186350 – Patch

[patch] Patch

bug-186350-20180606083639.patch (text/plain), 2.04 KB, created by Timothy Hatcher on 2018-06-06 08:36:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-06-06 08:36:40 PDT

Size: 2.04 KB

patch

obsolete

>Subversion Revision: 232524
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 4e0c983bf6852cd83224bc5b626677f56ab4ed45..15075a282cfd60860d77839bdda65d01f65dbc0e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-06  Timothy Hatcher  <timothy@apple.com>
>+
>+        Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=186350
>+        rdar://problem/39135535
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac/WebCoreFullScreenPlaceholderView.mm:
>+        (-[WebCoreFullScreenPlaceholderView initWithFrame:]):
>+        Use the NSVisualEffectMaterialFullScreenUI on macOS 10.14 and don't
>+        set an explicit NSAppearance.
>+
> 2018-06-05  Timothy Hatcher  <timothy@apple.com>
> 
>         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
>diff --git a/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm b/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm
>index b1faeb535b7d918de3618c00a20a12399607c288..760f58ee29031000c1f411670e04c405291a6e96 100644
>--- a/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm
>+++ b/Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm
>@@ -55,9 +55,15 @@ - (id)initWithFrame:(NSRect)frameRect
>     _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
>     _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow;
>     _effectView.get().hidden = YES;
>-    _effectView.get().material = NSVisualEffectMaterialLight;
>     _effectView.get().state = NSVisualEffectStateActive;
>+
>+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+    _effectView.get().material = NSVisualEffectMaterialPopover;
>+#else
>+    _effectView.get().material = NSVisualEffectMaterialLight;
>     _effectView.get().appearance = [NSAppearance appearanceNamed:NSAppearanceNameVibrantLight];
>+#endif
>+
>     [self addSubview:_effectView.get()];
> 
>     _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]);

Actions: View | Formatted Diff | Diff

Attachments on bug 186350: 342047 | 342048