Attachment 342026 Details for Bug 185889 – Patch

[patch] Patch

bug-185889-20180605205734.patch (text/plain), 3.42 KB, created by Jer Noble on 2018-06-05 20:57:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-06-05 20:57:36 PDT

Size: 3.42 KB

patch

obsolete

>Subversion Revision: 232471
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0226774f0100de7ae56abec42be0e29fe6a9af5b..9b4a109015910b079d4235348d6145f1251978ab 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-05  Jer Noble  <jer.noble@apple.com>
>+
>+        REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=185889
>+        <rdar://problem/40583180>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Explicitly update the network and ready states when detaching the AVPlayerItem
>+        from the AVPlayer.
>+
>+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
>+        (WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldBufferData):
>+
> 2018-06-05  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in
>diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>index 715f126da1ff305876d3986823e8aa0ae0889100..0e504b7a17ee9810a257e6c9e366c8dab6b9aa58 100644
>--- a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>+++ b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
>@@ -3066,6 +3066,7 @@ void MediaPlayerPrivateAVFoundationObjC::setShouldBufferData(bool shouldBuffer)
>         return;
> 
>     setAVPlayerItem(shouldBuffer ? m_avPlayerItem.get() : nil);
>+    updateStates();
> }
> 
> #if ENABLE(DATACUE_VALUE)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ec92a4e6c3db4c5fb30e2519d1414e6b2cdc6ece..27cc3e8a8d883ec341b7b0c08ff06f046ae61be4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-05  Jer Noble  <jer.noble@apple.com>
>+
>+        REGRESSION (r231817?): Layout Test media/track/track-delete-during-setup.html is a flaky timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=185889
>+        <rdar://problem/40583180>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Modify the track-delete-during-setup.html test to end on video element suspend in
>+        addition to canplaythrough.
>+
>+        * media/track/track-delete-during-setup.html:
>+
> 2018-06-05  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION (231817): Videos permanently blank out after switching out of a tab and back in
>diff --git a/LayoutTests/media/track/track-delete-during-setup.html b/LayoutTests/media/track/track-delete-during-setup.html
>index c249bbfc5580b975cbe45bab78a1cc2f45116472..01c3bd660b34ff1897b17ffa0db933dd04005f6f 100644
>--- a/LayoutTests/media/track/track-delete-during-setup.html
>+++ b/LayoutTests/media/track/track-delete-during-setup.html
>@@ -23,6 +23,11 @@
>                 setTimeout("endTest()", 100);
>             }
> 
>+            function suspend()
>+            {
>+                setTimeout("endTest()", 100);
>+            }
>+
>             function start()
>             {
>                 consoleWrite("<feOffset>");
>@@ -37,5 +42,5 @@
>             }
>         </script>
>     <body onload="start()">
>-<command><aside><kbd><video oncanplaythrough="canplaythrough()" > 
>+<command><aside><kbd><video oncanplaythrough="canplaythrough()" onsuspend="suspend()">
>             <track src="captions-webvtt/metadata.vtt" onload="metadataTrackLoaded()">

Actions: View | Formatted Diff | Diff

Attachments on bug 185889: 342026 | 342032