Attachment 341992 Details for Bug 186320 – Patch

[patch] Patch

bug-186320-20180605135709.patch (text/plain), 1.58 KB, created by Jeremy Jones on 2018-06-05 13:57:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-06-05 13:57:10 PDT

Size: 1.58 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3abbd15888ee227cd2c267ff839bc3e1edee6bea..6ffb9a653c80eba604a3e2ac98559c9bcdf7e2e8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-05  Jeremy Jones  <jeremyj@apple.com>
>+
>+        attenuationFactor should be in range [0,1]
>+        https://bugs.webkit.org/show_bug.cgi?id=186320
>+        rdar://problem/40821456
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If attenuationFactor is outside of this range it can cause false positives.
>+
>+        * UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:
>+        (WebKit::FullscreenTouchSecheuristic::attenuationFactor):
>+
> 2018-05-18  Brian Burg  <bburg@apple.com>
> 
>         [Cocoa] Add missing nullability annotations to _WKAutomationSessionDelegate
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp b/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp
>index 9e90701158ae212cd6ac778b03cdd5a71ee333a8..d0cf7a9f3aa17ea17ca5d89ef45bcd89d7c2cce8 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp
>@@ -78,7 +78,7 @@ double FullscreenTouchSecheuristic::distanceScore(const CGPoint& nextLocation, c
> double FullscreenTouchSecheuristic::attenuationFactor(Seconds delta)
> {
>     double normalizedTimeDelta = delta / m_rampDownSpeed;
>-    return normalizedTimeDelta * m_weight;
>+    return std::max(std::min(normalizedTimeDelta * m_weight, 1.0), 0.0);
> }
> 
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 186320: 341992