Attachment 341991 Details for Bug 186319 – Patch

[patch] Patch

bug-186319-20180605135136.patch (text/plain), 19.75 KB, created by Brent Fulgham on 2018-06-05 13:51:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-06-05 13:51:37 PDT

Size: 19.75 KB

patch

obsolete

>Subversion Revision: 232516
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 714379caf4279fd3d3c22a7c00e5f267b59efbc8..e4593189967d3eb33a4ec3d677c1a9f11192fc3f 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch revises the compile time and runtime state for various features to match their
>+        suitability for end-user releases.
>+
>+        * Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
>+        WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
>+        Cocoa builds.
>+        * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+        * runtime/Options.h: Only enable INTL_NUMBER_FORMAT_TO_PARTS and INTL_PLURAL_RULES
>+        at runtime for non-production builds.
>+
> 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
> 
>         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 9d10acbdd4957d918c074b0ea6e8774bdeb56c91..38e2254ec9b99554dcf91ca1903f9bfd316162ce 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+
> 2018-06-05  Youenn Fablet  <youenn@apple.com>
> 
>         ServiceWorker registration should store any script fetched through importScripts
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index d2172739af398d42063ffebcfbc2d75374488d4f..e3baf66b8fa61246cfc8a1c0314b5181096c407c 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
>+        WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
>+        Cocoa builds.
>+        * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+
> 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
> 
>         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d636609672fc828f4286bb58600793b2fce0fd07..125d8aa99ded98a8c3baedc60b75cc35ce7108ac 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Change the default state of various experimental features so that they are off by default in production
>+        builds, since they are still under development.
>+
>+        Turn 'CacheAPIEnabled' and 'SubresourceIntegrityEnabled' on by default, since both features have been
>+        shipping for a full cycle and have proven to be stable in production.
>+
>+        * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+        * Shared/WebPreferences.yaml: 
> 2018-06-05  Youenn Fablet  <youenn@apple.com>
> 
>         ServiceWorker registration should store any script fetched through importScripts
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 9ed70f2ed50668b9c1e3ae4eb51719833768fa89..f3565c7c8ff76acaebca94d20db66ff0a86c9287 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+        * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
>+        WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
>+        Cocoa builds.
>+
> 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
> 
>         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
>diff --git a/Source/JavaScriptCore/Configurations/DebugRelease.xcconfig b/Source/JavaScriptCore/Configurations/DebugRelease.xcconfig
>index 08fd1fc22993c309d9b8cb9beae011780e544ffd..8c928da2cfa8c815d8bbad920ab200daea147954 100644
>--- a/Source/JavaScriptCore/Configurations/DebugRelease.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/DebugRelease.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009, 2010, 2013, 2014 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
> // modification, are permitted provided that the following conditions
>@@ -43,5 +43,7 @@ SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
> SDKROOT_ = macosx;
> SDKROOT_YES = macosx.internal;
> 
>+WK_RELOCATABLE_FRAMEWORKS = YES;
>+
> WK_CCACHE_DIR = $(SRCROOT)/../../Tools/ccache;
> #include "../../../Tools/ccache/ccache.xcconfig"
>diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;
>diff --git a/Source/JavaScriptCore/runtime/Options.h b/Source/JavaScriptCore/runtime/Options.h
>index c7f192496e8768740ccc05b788cdc6df752cdd75..7e8c954f0abe533a3c7b25f2a890eaa404b25e01 100644
>--- a/Source/JavaScriptCore/runtime/Options.h
>+++ b/Source/JavaScriptCore/runtime/Options.h
>@@ -112,13 +112,13 @@ constexpr bool enableAsyncIteration = true;
> constexpr bool enableAsyncIteration = false;
> #endif
> 
>-#if ENABLE(INTL_NUMBER_FORMAT_TO_PARTS)
>+#if ENABLE(INTL_NUMBER_FORMAT_TO_PARTS) && (!PLATFORM(COCOA) || ENABLE(EXPERIMENTAL_FEATURES))
> constexpr bool enableIntlNumberFormatToParts = true;
> #else
> constexpr bool enableIntlNumberFormatToParts = false;
> #endif
> 
>-#if ENABLE(INTL_PLURAL_RULES)
>+#if ENABLE(INTL_PLURAL_RULES) && (!PLATFORM(COCOA) || ENABLE(EXPERIMENTAL_FEATURES))
> constexpr bool enableIntlPluralRules = true;
> #else
> constexpr bool enableIntlPluralRules = false;
>diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;
>diff --git a/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig b/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig
>index f0eca12c8bd9dc609e5a0685139662efbf2c7c3d..9b5ae4503746c39f830ea0f7d528338e3290c9bc 100644
>--- a/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig
>+++ b/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2017-2018 Apple Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
> // modification, are permitted provided that the following conditions
>@@ -43,5 +43,7 @@ SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
> SDKROOT_ = macosx;
> SDKROOT_YES = macosx.internal;
> 
>+WK_RELOCATABLE_FRAMEWORKS = YES;
>+
> WK_CCACHE_DIR = $(SRCROOT)/../../../Tools/ccache;
> #include "../../../../Tools/ccache/ccache.xcconfig"
>diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;
>diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index be55d1a3ed1cb3ffbca1edc3345b25327896e795..4189757db9591c1d5e9d87c4094d6ffe81a826ef 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -94,7 +94,7 @@ Accelerated2dCanvasEnabled:
> 
> CSSAnimationTriggersEnabled:
>   type: bool
>-  defaultValue: true
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>   webcoreBinding: RuntimeEnabledFeatures
>   webcoreName: animationTriggersEnabled
>   condition: ENABLE(CSS_ANIMATIONS_LEVEL_2)
>@@ -661,7 +661,7 @@ MenuItemElementEnabled:
> 
> EncryptedMediaAPIEnabled:
>   type: bool
>-  defaultValue: true
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>   humanReadableName: "Modern Encrypted Media API"
>   humanReadableDescription: "Modern Encrypted Media API"
>   webcoreBinding: RuntimeEnabledFeatures
>@@ -1077,7 +1077,7 @@ AsyncFrameScrollingEnabled:
> 
> CacheAPIEnabled:
>   type: bool
>-  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>+  defaultValue: true
>   humanReadableName: "Cache API"
>   humanReadableDescription: "Enable Cache API"
>   category: experimental
>@@ -1113,7 +1113,7 @@ SpringTimingFunctionEnabled:
> 
> ImageBitmapOffscreenCanvasEnabled:
>   type: bool
>-  defaultValue: true
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>   humanReadableName: "ImageBitmap and OffscreenCanvas"
>   humanReadableDescription: "Support for the ImageBitmap and OffscreenCanvas APIs"
>   category: experimental
>@@ -1180,7 +1180,7 @@ StorageAccessAPIEnabled:
> 
> SubresourceIntegrityEnabled:
>   type: bool
>-  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>+  defaultValue: true
>   humanReadableName: "SubresourceIntegrity"
>   humanReadableDescription: "Enable SubresourceIntegrity"
>   category: experimental
>diff --git a/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig b/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig
>index a802a76716099a3e9be469b3252e0f1483d7995d..439c11626ef2dde3b627a1fcab967f9575012e37 100644
>--- a/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009, 2010, 2013, 2014 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
> // modification, are permitted provided that the following conditions
>@@ -43,5 +43,7 @@ SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK));
> SDKROOT_ = macosx;
> SDKROOT_YES = macosx.internal;
> 
>+WK_RELOCATABLE_FRAMEWORKS = YES;
>+
> WK_CCACHE_DIR = $(SRCROOT)/../../Tools/ccache;
> #include "../../../../Tools/ccache/ccache.xcconfig"
>diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index da63e324bcc5eed189fa912a95c59e857efebacf..061ae8c298474863b3a2592ca2a9327f5d4e7196 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-05  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Adjust compile and runtime flags to match shippable state of features
>+        https://bugs.webkit.org/show_bug.cgi?id=186319
>+        <rdar://problem/40352045>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch revises the compile time and runtime state for various features to match their
>+        suitability for end-user releases.
>+
>+        * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
>+        WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
>+        Cocoa builds.
>+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
>+        or ENABLE_INPUT_TYPE_COLOR_POPOVER.
>+
> 2018-06-05  Youenn Fablet  <youenn@apple.com>
> 
>         ServiceWorker registration should store any script fetched through importScripts
>diff --git a/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig b/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig
>index 55f2967bc20947fabbad85a24df0a726398db776..37d1df648f074159e9b20c2c84ed2be5ec61f323 100644
>--- a/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig
>+++ b/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig
>@@ -44,5 +44,7 @@ SDKROOT_YES = macosx.internal;
> 
> OTHER_CPLUSPLUSFLAGS = $(inherited) -ftemplate-depth=256;
> 
>+WK_RELOCATABLE_FRAMEWORKS = YES;
>+
> WK_CCACHE_DIR = $(SRCROOT)/../ccache;
> #include "../../ccache/ccache.xcconfig"
>diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>index 9b133c2089f03196598c88e995e77220783a93a5..1b9186da5f9500b6adb37fa3b7ca236e215f99c8 100644
>--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>@@ -1,4 +1,4 @@
>-// Copyright (C) 2009-2017 Apple Inc. All rights reserved.
>+// Copyright (C) 2009-2018 Apple Inc. All rights reserved.
> // Copyright (C) 2009 Google Inc. All rights reserved.
> //
> // Redistribution and use in source and binary forms, with or without
>@@ -171,11 +171,9 @@ ENABLE_INDEXED_DATABASE = ENABLE_INDEXED_DATABASE;
> 
> ENABLE_INDEXED_DATABASE_IN_WORKERS = ENABLE_INDEXED_DATABASE_IN_WORKERS;
> 
>-ENABLE_INPUT_TYPE_COLOR = $(ENABLE_INPUT_TYPE_COLOR_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_macosx = ENABLE_INPUT_TYPE_COLOR;
>+ENABLE_INPUT_TYPE_COLOR = ;
> 
>-ENABLE_INPUT_TYPE_COLOR_POPOVER = $(ENABLE_INPUT_TYPE_COLOR_POPOVER_$(WK_PLATFORM_NAME));
>-ENABLE_INPUT_TYPE_COLOR_POPOVER_macosx = ENABLE_INPUT_TYPE_COLOR_POPOVER;
>+ENABLE_INPUT_TYPE_COLOR_POPOVER = ;
> 
> ENABLE_INPUT_TYPE_DATETIMELOCAL = $(ENABLE_INPUT_TYPE_DATETIMELOCAL_$(WK_COCOA_TOUCH));
> ENABLE_INPUT_TYPE_DATETIMELOCAL_cocoatouch = ENABLE_INPUT_TYPE_DATETIMELOCAL;

Actions: View | Formatted Diff | Diff

Attachments on bug 186319: 341991 | 341998 | 341999 | 342000 | 342001 | 342002 | 342063