Attachment 341989 Details for Bug 186283 – Patch

[patch] Patch

bug-186283-20180605133205.patch (text/plain), 3.15 KB, created by Dawei Fenton (:realdawei) on 2018-06-05 13:32:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dawei Fenton (:realdawei)

Created: 2018-06-05 13:32:06 PDT

Size: 3.15 KB

patch

obsolete

>Subversion Revision: 232519
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index f541ac78a0c1de337c95501be875695cb45c024d..57c7bdc13792626b57853fbc4761cd6a1023dd4f 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-05  David Fenton  <david_fenton@apple.com>
>+
>+        Temporarily Skip JSC stress test failures that are consistently occurring.
>+        https://bugs.webkit.org/show_bug.cgi?id=186283
>+
>+        Unreviewed test gardening.
>+
>+        * executableAllocationFuzz.yaml:
>+        * slowMicrobenchmarks/default-derived-constructor.js:
>+        * stress/put-direct-index-broken-2.js:
>+        * stress/splay-flash-access.js:
>+        * stress/spread-forward-call-varargs-stack-overflow.js:
>+
> 2018-06-04  Keith Miller  <keith_miller@apple.com>
> 
>         Add test for CoW conversions in the DFG/FTL
>diff --git a/JSTests/executableAllocationFuzz.yaml b/JSTests/executableAllocationFuzz.yaml
>index b0ea004cb9d63df508404bb7c1a91cf7b67ee0e5..9d63db9674cabdc05eada76916b51fd87216a212 100644
>--- a/JSTests/executableAllocationFuzz.yaml
>+++ b/JSTests/executableAllocationFuzz.yaml
>@@ -23,7 +23,7 @@
> 
> - path: executableAllocationFuzz
>   cmd: |
>-      if ($hostOS == "windows")
>+      if ($hostOS == "windows" || $architecture == "x86")
>           skip
>       else
>           runExecutableAllocationFuzz("default")
>diff --git a/JSTests/slowMicrobenchmarks/default-derived-constructor.js b/JSTests/slowMicrobenchmarks/default-derived-constructor.js
>index d081511a50af3c787dbc74dc7b60386026b70734..1e471cb798fa4d131e1020ddadfffb88437f721a 100644
>--- a/JSTests/slowMicrobenchmarks/default-derived-constructor.js
>+++ b/JSTests/slowMicrobenchmarks/default-derived-constructor.js
>@@ -1,3 +1,4 @@
>+//@skip if $architecture == "x86"
> function createClassHierarchy(depth) {
>     let currentClass = class Base { };
>     for (let i = 0; i < depth; i++) {
>diff --git a/JSTests/stress/put-direct-index-broken-2.js b/JSTests/stress/put-direct-index-broken-2.js
>index 1f47a91db70d68fe488ea07db075df15c78793c1..dad277c0bfa0ba1e152ff78cc2a0097b8a81eff5 100644
>--- a/JSTests/stress/put-direct-index-broken-2.js
>+++ b/JSTests/stress/put-direct-index-broken-2.js
>@@ -1,3 +1,4 @@
>+//@skip if $architecture == "x86"
> function assert(b) {
>     if (!b)
>         throw new Error("Bad assertion");
>diff --git a/JSTests/stress/splay-flash-access.js b/JSTests/stress/splay-flash-access.js
>index ee0757dc39ecd2b046d1f173ed0dbd1049debd88..81e7a3248738f0ff885958339f1c7e07f4b818e2 100644
>--- a/JSTests/stress/splay-flash-access.js
>+++ b/JSTests/stress/splay-flash-access.js
>@@ -1,4 +1,4 @@
>-//@skip if $memoryLimited
>+//@skip if $memoryLimited || $architecture == "x86"
> //@ runNoisyTestDefault
> //@ runNoisyTestNoCJIT
> 
>diff --git a/JSTests/stress/spread-forward-call-varargs-stack-overflow.js b/JSTests/stress/spread-forward-call-varargs-stack-overflow.js
>index ed82286b6b095a5c95883a95d8f56209c55d6672..9b1eca4dab4eec813c51ae0410e52a182850754a 100644
>--- a/JSTests/stress/spread-forward-call-varargs-stack-overflow.js
>+++ b/JSTests/stress/spread-forward-call-varargs-stack-overflow.js
>@@ -1,3 +1,4 @@
>+//@skip if $architecture == "x86"
> function assert(b) {
>     if (!b)
>         throw new Error("Bad assertion");

Actions: View | Formatted Diff | Diff

Attachments on bug 186283: 341981 | 341989 | 341993