Attachment 341988 Details for Bug 186318 – Patch

[patch] Patch

bug-186318-20180605132500.patch (text/plain), 1.79 KB, created by Jeremy Jones on 2018-06-05 13:25:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-06-05 13:25:01 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3abbd15888ee227cd2c267ff839bc3e1edee6bea..d37ebece095a0d7b30058b44ddd486148e71f9af 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-05  Jeremy Jones  <jeremyj@apple.com>
>+
>+        secheuristic should only use touch began and ended, not changed.
>+        https://bugs.webkit.org/show_bug.cgi?id=186318
>+        rdar://problem/39781486
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Filter out change events so swiping gestures don't trigger the heuristic.
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
>+        (-[WKFullScreenViewController _touchDetected:]):
>+
> 2018-05-18  Brian Burg  <bburg@apple.com>
> 
>         [Cocoa] Add missing nullability annotations to _WKAutomationSessionDelegate
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>index 0c7d48db3157374091cdd59ded4f69cc8912a935..9a17044648b39b05013a1e8bfbc31978e137a289 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>@@ -393,7 +393,7 @@ - (void)_togglePiPAction:(id)sender
> 
> - (void)_touchDetected:(id)sender
> {
>-    if ([_touchGestureRecognizer state] != UIGestureRecognizerStateBegan || [_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
>+    if ([_touchGestureRecognizer state] == UIGestureRecognizerStateBegan || [_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
>         double score = _secheuristic.scoreOfNextTouch([_touchGestureRecognizer locationInView:self.view]);
>         if (score > requiredScore)
>             [self _showPhishingAlert];

Actions: View | Formatted Diff | Diff

Attachments on bug 186318: 341988