Attachment 341964 Details for Bug 186305 – Patch

[patch] Patch

bug-186305-20180605131458.patch (text/plain), 3.70 KB, created by Antoine Quint on 2018-06-05 04:14:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2018-06-05 04:14:59 PDT

Size: 3.70 KB

patch

obsolete

>Subversion Revision: 232504
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8bd67f23582eafde95c57214f88fca7aac7c3cd9..ee0d7e09ed5ad80d7ff5f34eae10c3251e7abde5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-05  Antoine Quint  <graouts@apple.com>
>+
>+        [Web Animations] Only expose CSSAnimation and CSSTransition if the WebAnimationsCSSIntegration runtime flag is enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=186305
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * animation/CSSAnimation.idl:
>+        * animation/CSSTransition.idl:
>+
> 2018-06-03  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] Update more code to be more ARC-compatible to prepare for future ARC adoption
>diff --git a/Source/WebCore/animation/CSSAnimation.idl b/Source/WebCore/animation/CSSAnimation.idl
>index 6917e7b6c2fdccacdb0d86853c3ca2e7b5a67196..1e5b884a9a67ca529176e39ef68295af8f615cb4 100644
>--- a/Source/WebCore/animation/CSSAnimation.idl
>+++ b/Source/WebCore/animation/CSSAnimation.idl
>@@ -26,7 +26,7 @@
> typedef USVString CSSOMString;
> 
> [
>-    EnabledAtRuntime=WebAnimations,
>+    EnabledAtRuntime=WebAnimationsCSSIntegration,
>     Exposed=Window
> ] interface CSSAnimation : WebAnimation {
>     readonly attribute CSSOMString animationName;
>diff --git a/Source/WebCore/animation/CSSTransition.idl b/Source/WebCore/animation/CSSTransition.idl
>index 90f2d71e25a7dfdda9806b41ea20f34c7078bb0f..194c6af1b5adfd06d27cfc040c4cc197fc23672f 100644
>--- a/Source/WebCore/animation/CSSTransition.idl
>+++ b/Source/WebCore/animation/CSSTransition.idl
>@@ -26,7 +26,7 @@
> typedef USVString CSSOMString;
> 
> [
>-    EnabledAtRuntime=WebAnimations,
>+    EnabledAtRuntime=WebAnimationsCSSIntegration,
>     Exposed=Window
> ] interface CSSTransition : WebAnimation {
>     readonly attribute CSSOMString transitionProperty;
>diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog
>index 3591736b30c030bb5221f60b8a91ff00084d744f..e4ad0988ec58c96ed2b2fdcbb9c606a74c65bcb4 100644
>--- a/Websites/webkit.org/ChangeLog
>+++ b/Websites/webkit.org/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-05  Antoine Quint  <graouts@apple.com>
>+
>+        [Web Animations] Only expose CSSAnimation and CSSTransition if the WebAnimationsCSSIntegration runtime flag is enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=186305
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a test for the WebAnimationsCSSIntegration runtime flag.
>+
>+        * experimental-features.html:
>+
> 2018-06-01  Dean Jackson  <dino@apple.com>
> 
>         Add a demo for passive touch listeners.
>diff --git a/Websites/webkit.org/experimental-features.html b/Websites/webkit.org/experimental-features.html
>index 1dc54989d803d763210e537620599d81a3f55b6f..6a3f6974adc5c30ba867e16a350431c7cc6b3455 100644
>--- a/Websites/webkit.org/experimental-features.html
>+++ b/Websites/webkit.org/experimental-features.html
>@@ -94,6 +94,10 @@ function testWebAnimations() {
>     return !!window.Animation;
> }
> 
>+function testWebAnimationsCSSIntegration() {
>+    return !!window.CSSAnimation;
>+}
>+
> function testWebGL2() {
>     let canvas = document.createElement("canvas");
>     return canvas.getContext("webgl2");
>@@ -146,6 +150,7 @@ window.addEventListener("load", function () {
>         <div class="test" id="SubtleCrypto"><p>SubtleCrypto</p></div>
>         <div class="test" id="VariationFonts"><p>Variation Fonts</p></div>
>         <div class="test" id="WebAnimations"><p>Web Animations</p></div>
>+        <div class="test" id="WebAnimationsCSSIntegration"><p>Web Animations and CSS Integration</p></div>
>         <div class="test" id="WebGL2"><p>WebGL 2.0</p></div>
>         <div class="test" id="WebGPU"><p>WebGPU</p></div>
>         <div class="test" id="WebRTC"><p>WebRTC</p></div>

Flags:

dino: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 186305: 341964 | 341965