Attachment 341958 Details for Bug 186274 – Patch

[patch] Patch

bug-186274-20180605111131.patch (text/plain), 21.35 KB, created by Joanmarie Diggs on 2018-06-05 02:11:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joanmarie Diggs

Created: 2018-06-05 02:11:33 PDT

Size: 21.35 KB

patch

obsolete

>Subversion Revision: 232464
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 64b0f12a6de55cb72ed70ddca1a2e5dbed50fad5..02a7f8e6a3f4f8c22c45f46cd6f57a029f63a37a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-06-05  Joanmarie Diggs  <jdiggs@igalia.com>
>+
>+        AX: Implement support for new blockquote, caption, and paragraph ARIA roles
>+        https://bugs.webkit.org/show_bug.cgi?id=186274
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add the three new ARIA roles to the internal rolemap so that they are treated in
>+        the same fashion as their HTML element counterparts. Also ensure that an element
>+        with an explicit caption role does not get pruned from the macOS accessibility tree.
>+
>+        No new tests. Instead add the roles to the existing role-exposure tests.
>+
>+        * accessibility/AccessibilityObject.cpp:
>+        (WebCore::initializeRoleMap):
>+        * accessibility/mac/AccessibilityObjectMac.mm:
>+        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
>+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
>+        (createAccessibilityRoleMap):
>+
> 2018-06-03  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         REGRESSION(r232338): [GTK] Broke a few layout tests
>diff --git a/Source/WebCore/accessibility/AccessibilityObject.cpp b/Source/WebCore/accessibility/AccessibilityObject.cpp
>index 6e49c8034d7abb5f9480ef19151516d6f3b34337..0c1abc4d5e8551835f052e75a9c2007d5461fb36 100644
>--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
>+++ b/Source/WebCore/accessibility/AccessibilityObject.cpp
>@@ -2290,7 +2290,9 @@ static void initializeRoleMap()
>         { "application", AccessibilityRole::WebApplication },
>         { "article", AccessibilityRole::DocumentArticle },
>         { "banner", AccessibilityRole::LandmarkBanner },
>+        { "blockquote", AccessibilityRole::Blockquote },
>         { "button", AccessibilityRole::Button },
>+        { "caption", AccessibilityRole::Caption },
>         { "checkbox", AccessibilityRole::CheckBox },
>         { "complementary", AccessibilityRole::LandmarkComplementary },
>         { "contentinfo", AccessibilityRole::LandmarkContentInfo },
>@@ -2373,6 +2375,7 @@ static void initializeRoleMap()
>         { "note", AccessibilityRole::DocumentNote },
>         { "navigation", AccessibilityRole::LandmarkNavigation },
>         { "option", AccessibilityRole::ListBoxOption },
>+        { "paragraph", AccessibilityRole::Paragraph },
>         { "presentation", AccessibilityRole::Presentational },
>         { "progressbar", AccessibilityRole::ProgressIndicator },
>         { "radio", AccessibilityRole::RadioButton },
>diff --git a/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm b/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
>index af199d7654883a5ecf6848134c1e2e1f026d1aef..cce972cfcd02e5754eccecc578fa4b40a9968c26 100644
>--- a/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
>+++ b/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
>@@ -84,7 +84,7 @@ AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO
>     if (isMenuListPopup() || isMenuListOption())
>         return AccessibilityObjectInclusion::IgnoreObject;
> 
>-    if (roleValue() == AccessibilityRole::Caption)
>+    if (roleValue() == AccessibilityRole::Caption && ariaRoleAttribute() == AccessibilityRole::Unknown)
>         return AccessibilityObjectInclusion::IgnoreObject;
>     
>     if (roleValue() == AccessibilityRole::Mark)
>diff --git a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>index d1a2095a2faef8c24290cd9cc42e9ac967e43097..e2c940ef531d46feca98686147780dcbfe2a0f2a 100644
>--- a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>+++ b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
>@@ -1992,6 +1992,7 @@ static const AccessibilityRoleMap& createAccessibilityRoleMap()
>         { AccessibilityRole::GraphicsDocument, NSAccessibilityGroupRole },
>         { AccessibilityRole::GraphicsObject, NSAccessibilityGroupRole },
>         { AccessibilityRole::GraphicsSymbol, NSAccessibilityImageRole },
>+        { AccessibilityRole::Caption, NSAccessibilityGroupRole },
>     };
>     AccessibilityRoleMap& roleMap = *new AccessibilityRoleMap;
>     
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b4f6d377da2561a53d0e75fbef822b403333b411..c6fe30ce2e578745714b74e3299821917b887c6c 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,27 @@
>+2018-06-05  Joanmarie Diggs  <jdiggs@igalia.com>
>+
>+        AX: Implement support for new blockquote, caption, and paragraph ARIA roles
>+        https://bugs.webkit.org/show_bug.cgi?id=186274
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add the three ARIA roles to the existing role-exposure tests and update
>+        expectations accordingly. Also update several additional GTK tests because
>+        the mapping of these ARIA roles results in new object attributes appearing
>+        for native HTML blockquote, paragraph, and caption elements.
>+
>+        * accessibility/gtk/object-attributes-expected.txt:
>+        * accessibility/gtk/xml-roles-exposed-expected.txt:
>+        * accessibility/gtk/xml-roles-exposed.html:
>+        * accessibility/roles-computedRoleString-expected.txt:
>+        * accessibility/roles-computedRoleString.html:
>+        * accessibility/roles-exposed.html:
>+        * platform/gtk/accessibility/roles-computedRoleString-expected.txt:
>+        * platform/gtk/accessibility/roles-exposed-expected.txt:
>+        * platform/gtk/accessibility/table-one-cell-expected.txt:
>+        * platform/mac/accessibility/roles-computedRoleString-expected.txt:
>+        * platform/mac/accessibility/roles-exposed-expected.txt:
>+
> 2018-06-04  Zan Dobersek  <zdobersek@igalia.com>
> 
>         Unreviewed WPE gardening.
>diff --git a/LayoutTests/accessibility/gtk/object-attributes-expected.txt b/LayoutTests/accessibility/gtk/object-attributes-expected.txt
>index c294348538f5e356b58a39d67f30a9d5c42cec28..16e2b29ea353649dae6c7412715f11b0e60c86dc 100644
>--- a/LayoutTests/accessibility/gtk/object-attributes-expected.txt
>+++ b/LayoutTests/accessibility/gtk/object-attributes-expected.txt
>@@ -232,7 +232,7 @@ AXEnabled: 1
> AXExpanded: 0
> AXRequired: 0
> AXChecked: 0
>-AXPlatformAttributes: html-id:description, tag:p, toolkit:WebKitGtk
>+AXPlatformAttributes: computed-role:paragraph, html-id:description, tag:p, toolkit:WebKitGtk
> ------------
> 
> PASS successfullyParsed is true
>diff --git a/LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt b/LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt
>index da6139625d5737c35f149bc0b6379704f5bb3a88..afd40be4ea81aa0a9cfb5b576172ac0566c80094 100644
>--- a/LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt
>+++ b/LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt
>@@ -98,6 +98,25 @@ AXRequired: 0
> AXChecked: 0
> AXPlatformAttributes: computed-role:banner, xml-roles:banner, tag:div, toolkit:WebKitGtk
> ------------
>+AXRole: AXBlockquote
>+AXParent: AXWebArea
>+AXChildren: 0
>+AXPosition: { 0.000000, 0.000000 }
>+AXSize: { 0.000000, 0.000000 }
>+AXTitle: 
>+AXDescription: 
>+AXValue: 
>+AXFocusable: 0
>+AXFocused: 0
>+AXSelectable: 0
>+AXSelected: 0
>+AXMultiSelectable: 0
>+AXEnabled: 1
>+AXExpanded: 0
>+AXRequired: 0
>+AXChecked: 0
>+AXPlatformAttributes: computed-role:blockquote, xml-roles:blockquote, tag:div, toolkit:WebKitGtk
>+------------
> AXRole: AXButton
> AXParent: AXWebArea
> AXChildren: 0
>@@ -117,6 +136,25 @@ AXRequired: 0
> AXChecked: 0
> AXPlatformAttributes: computed-role:button, xml-roles:button, tag:div, toolkit:WebKitGtk
> ------------
>+AXRole: AXCaption
>+AXParent: AXWebArea
>+AXChildren: 0
>+AXPosition: { 0.000000, 0.000000 }
>+AXSize: { 0.000000, 0.000000 }
>+AXTitle: 
>+AXDescription: 
>+AXValue: 
>+AXFocusable: 0
>+AXFocused: 0
>+AXSelectable: 0
>+AXSelected: 0
>+AXMultiSelectable: 0
>+AXEnabled: 1
>+AXExpanded: 0
>+AXRequired: 0
>+AXChecked: 0
>+AXPlatformAttributes: computed-role:caption, xml-roles:caption, tag:div, toolkit:WebKitGtk
>+------------
> AXRole: AXCheckBox
> AXParent: AXWebArea
> AXChildren: 0
>@@ -517,6 +555,25 @@ AXRequired: 0
> AXChecked: 0
> AXPlatformAttributes: computed-role:note, xml-roles:note, tag:div, toolkit:WebKitGtk
> ------------
>+AXRole: AXParagraph
>+AXParent: AXWebArea
>+AXChildren: 0
>+AXPosition: { 0.000000, 0.000000 }
>+AXSize: { 0.000000, 0.000000 }
>+AXTitle: 
>+AXDescription: 
>+AXValue: 
>+AXFocusable: 1
>+AXFocused: 0
>+AXSelectable: 0
>+AXSelected: 0
>+AXMultiSelectable: 0
>+AXEnabled: 1
>+AXExpanded: 0
>+AXRequired: 0
>+AXChecked: 0
>+AXPlatformAttributes: computed-role:paragraph, xml-roles:paragraph, tag:div, toolkit:WebKitGtk
>+------------
> AXRole: AXProgressIndicator
> AXParent: AXWebArea
> AXChildren: 0
>@@ -1659,7 +1716,7 @@ AXEnabled: 1
> AXExpanded: 0
> AXRequired: 0
> AXChecked: 0
>-AXPlatformAttributes: html-id:description, tag:p, toolkit:WebKitGtk
>+AXPlatformAttributes: computed-role:paragraph, html-id:description, tag:p, toolkit:WebKitGtk
> ------------
> 
> PASS successfullyParsed is true
>diff --git a/LayoutTests/accessibility/gtk/xml-roles-exposed.html b/LayoutTests/accessibility/gtk/xml-roles-exposed.html
>index a3e10d808ea8d45f31d0807ec073f12430a4207f..b858a4b949e171c6f612943ca0df5ebefb388b8e 100644
>--- a/LayoutTests/accessibility/gtk/xml-roles-exposed.html
>+++ b/LayoutTests/accessibility/gtk/xml-roles-exposed.html
>@@ -10,7 +10,9 @@
>  <div role="application"></div>
>  <div role="article"></div>
>  <div role="banner"></div>
>+ <div role="blockquote"></div>
>  <div role="button"></div>
>+ <div role="caption"></div>
>  <div role="checkbox"></div>
>  <div role="combobox"></div>
>  <div role="complementary"></div>
>@@ -32,6 +34,7 @@
>  <div role="math"></div>
>  <div role="navigation"></div>
>  <div role="note"></div>
>+ <div role="paragraph"></div>
>  <div role="presentation"></div>
>  <div role="progressbar"></div>
>  <div role="radio"></div>
>diff --git a/LayoutTests/accessibility/roles-computedRoleString-expected.txt b/LayoutTests/accessibility/roles-computedRoleString-expected.txt
>index 6e004f5504f5f33dd12509aaef1a906f3d84be08..27787712b92193230bf03e0b43930b60df86debf 100644
>--- a/LayoutTests/accessibility/roles-computedRoleString-expected.txt
>+++ b/LayoutTests/accessibility/roles-computedRoleString-expected.txt
>@@ -47,7 +47,7 @@ PASS: meter -> progressbar.
> PASS: nav -> navigation. 
> PASS: ol -> list. 
> PASS: li -> listitem. 
>-PASS: p -> . 
>+PASS: p -> paragraph. 
> PASS: pre -> group. 
> PASS: progress -> progressbar. 
> PASS: samp -> . 
>@@ -63,6 +63,7 @@ PASS: option -> option.
> PASS: sub -> . 
> PASS: sup -> . 
> PASS: table -> table. 
>+PASS: caption -> caption. 
> PASS: tr -> row. 
> PASS: th -> columnheader. 
> PASS: tr -> row. 
>@@ -97,7 +98,9 @@ PASS: div[role="alertdialog"] -> alertdialog.
> PASS: div[role="application"] -> application. 
> PASS: div[role="article"] -> article. 
> PASS: div[role="banner"] -> banner. 
>+PASS: div[role="blockquote"] -> blockquote. 
> PASS: div[role="button"] -> button. 
>+PASS: div[role="caption"] -> caption. 
> PASS: div[role="checkbox"] -> checkbox. 
> PASS: div[role="combobox"] -> combobox. 
> PASS: div[role="complementary"] -> complementary. 
>@@ -134,6 +137,7 @@ PASS: div[role="menuitemcheckbox"] -> menuitemcheckbox.
> PASS: div[role="menuitemradio"] -> menuitemradio. 
> PASS: div[role="navigation"] -> navigation. 
> PASS: div[role="note"] -> note. 
>+PASS: div[role="paragraph"] -> paragraph. 
> PASS: div[role="progressbar"] -> progressbar. 
> PASS: div[role="radiogroup"] -> radiogroup. 
> PASS: div[role="radio"] -> radio. 
>diff --git a/LayoutTests/accessibility/roles-computedRoleString.html b/LayoutTests/accessibility/roles-computedRoleString.html
>index efcc1b4aed9166de3fa50a64df56b0c1c23977e7..9df76409bc252481877235c03d2c226a290ceb2b 100644
>--- a/LayoutTests/accessibility/roles-computedRoleString.html
>+++ b/LayoutTests/accessibility/roles-computedRoleString.html
>@@ -68,7 +68,7 @@
> 
> 
> 
>-<p data-role="" data-platform="atk,mac" class="ex">X</p>
>+<p data-role="paragraph" data-platform="atk,mac" class="ex">X</p>
> 
> <pre data-role="" data-platform="atk,mac" class="ex">X</pre>
> <progress data-role="progressbar" data-platform="atk,mac" class="ex" value="0.75">X</progress>
>@@ -103,7 +103,7 @@
> <svg data-role="" data-platform="atk,mac" class="ex">X</svg>
> 
> <table data-role="table" data-platform="atk,mac" class="ex">
>-    <caption data-role="" data-platform="atk,mac" class="ex">X</caption>
>+    <caption data-role="caption" data-platform="atk,mac" class="ex">X</caption>
>     <thead data-role="rowgroup" data-platform="atk,mac" class="ex">
>         <tr data-role="row" data-platform="atk,mac" class="ex">
>             <th data-role="columnheader" data-platform="atk,mac" class="ex">X</th>
>@@ -173,7 +173,9 @@
> <div role="application"              data-role="application" data-platform="atk,mac" class="ex">X</div>
> <div role="article"                  data-role="article" data-platform="atk,mac" class="ex">X</div>
> <div role="banner"                   data-role="banner" data-platform="atk,mac" class="ex">X</div>
>+<div role="blockquote"               data-role="blockquote" data-platform="atk,mac" class="ex">X</div>
> <div role="button"                   data-role="button" data-platform="atk,mac" class="ex">X</div>
>+<div role="caption"                  data-role="caption" data-platform="atk,mac" class="ex">X</div>
> <div role="checkbox"                 data-role="checkbox" data-platform="atk,mac" class="ex">X</div>
> <div role="combobox"                 data-role="combobox" data-platform="atk,mac" class="ex">X</div>
> <div role="complementary"            data-role="complementary" data-platform="atk,mac" class="ex">X</div>
>@@ -223,6 +225,7 @@
> </div>
> <div role="navigation"               data-role="navigation" data-platform="atk,mac" class="ex">X</div>
> <div role="note"                     data-role="note" data-platform="atk,mac" class="ex">X</div>
>+<div role="paragraph"                data-role="paragraph" data-platform="atk,mac" class="ex">X</div>
> <div role="presentation"             data-role="" data-platform="atk,mac" class="ex">X</div>
> <div role="progressbar"              data-role="progressbar" data-platform="atk,mac" class="ex">X</div>
> <div role="radiogroup"               data-role="radiogroup" data-platform="atk,mac" class="ex">
>diff --git a/LayoutTests/accessibility/roles-exposed.html b/LayoutTests/accessibility/roles-exposed.html
>index 0eea2374d4727993c384319d41cab8a85ee27f72..35ab60104620ac7f32943d0baf814e23a1a2ce68 100644
>--- a/LayoutTests/accessibility/roles-exposed.html
>+++ b/LayoutTests/accessibility/roles-exposed.html
>@@ -248,7 +248,9 @@
> <div role="application"              data-platform="atk,mac" class="ex">X</div>
> <div role="article"                  data-platform="atk,mac" class="ex">X</div>
> <div role="banner"                   data-platform="atk,mac" class="ex">X</div>
>+<div role="blockquote"               data-platform="atk,mac" class="ex">X</div>
> <div role="button"                   data-platform="atk,mac" class="ex">X</div>
>+<div role="caption"                  data-platform="atk,mac" class="ex">X</div>
> <div role="checkbox"                 data-platform="atk,mac" class="ex">X</div>
> <div role="combobox"                 data-platform="atk,mac" class="ex">X</div>
> <div role="complementary"            data-platform="atk,mac" class="ex">X</div>
>@@ -342,6 +344,7 @@
> </div>
> <div role="navigation"               data-platform="atk,mac" class="ex">X</div>
> <div role="note"                     data-platform="atk,mac" class="ex">X</div>
>+<div role="paragraph"                data-platform="atk,mac" class="ex">X</div>
> <div role="presentation"             data-platform="atk,mac" class="ex">X</div>
> <div role="progressbar"              data-platform="atk,mac" class="ex">X</div>
> <div role="radiogroup"               data-platform="atk,mac" class="ex">
>diff --git a/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt b/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
>index 47cc62a87eee41ff110cc4bddfeb273b6237e042..738b8477342e370d6ab01488ffd54a9dfd69917f 100644
>--- a/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
>+++ b/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
>@@ -46,7 +46,7 @@ PASS: math -> math.
> PASS: nav -> navigation. 
> PASS: ol -> list. 
> PASS: li -> listitem. 
>-PASS: p -> . 
>+PASS: p -> paragraph. 
> PASS: pre -> . 
> PASS: progress -> progressbar. 
> PASS: samp -> . 
>@@ -64,7 +64,7 @@ PASS: option -> option.
> PASS: sub -> . 
> PASS: sup -> . 
> PASS: table -> table. 
>-PASS: caption -> . 
>+PASS: caption -> caption. 
> PASS: tr -> row. 
> PASS: th -> columnheader. 
> PASS: tr -> row. 
>@@ -100,7 +100,9 @@ PASS: div[role="alertdialog"] -> alertdialog.
> PASS: div[role="application"] -> application. 
> PASS: div[role="article"] -> article. 
> PASS: div[role="banner"] -> banner. 
>+PASS: div[role="blockquote"] -> blockquote. 
> PASS: div[role="button"] -> button. 
>+PASS: div[role="caption"] -> caption. 
> PASS: div[role="checkbox"] -> checkbox. 
> PASS: div[role="combobox"] -> combobox. 
> PASS: div[role="complementary"] -> complementary. 
>@@ -142,6 +144,7 @@ PASS: div[role="menuitemcheckbox"] -> menuitemcheckbox.
> PASS: div[role="menuitemradio"] -> menuitemradio. 
> PASS: div[role="navigation"] -> navigation. 
> PASS: div[role="note"] -> note. 
>+PASS: div[role="paragraph"] -> paragraph. 
> PASS: div[role="progressbar"] -> progressbar. 
> PASS: div[role="radiogroup"] -> radiogroup. 
> PASS: div[role="radio"] -> radio. 
>diff --git a/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt b/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
>index 029cdbdb1bf06242c9adeb2001e46c6f10d740fa..e5913dd0e0d5618970a7e19ca046328f4fa84470 100644
>--- a/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
>+++ b/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
>@@ -499,9 +499,15 @@ div[role=article]
> div[role=banner]
>       AXRole: AXLandmarkBanner
>       
>+div[role=blockquote]
>+      AXRole: AXBlockquote
>+      
> div[role=button]
>       AXRole: AXButton
>       
>+div[role=caption]
>+      AXRole: AXCaption
>+      
> div[role=checkbox]
>       AXRole: AXCheckBox
>       
>@@ -745,6 +751,9 @@ div[role=navigation]
> div[role=note]
>       AXRole: AXComment
>       
>+div[role=paragraph]
>+      AXRole: AXParagraph
>+      
> div[role=presentation]
>       AXRole: 
>       
>diff --git a/LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt b/LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt
>index f990261459034cb8010586fdb2b6bd96bb899f85..aac6249dc27ba3dd4d0a15d256959695a44b847a 100644
>--- a/LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt
>+++ b/LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt
>@@ -18,4 +18,4 @@ AXEnabled: 1
> AXExpanded: 0
> AXRequired: 0
> AXChecked: 0
>-AXPlatformAttributes: tag:p, toolkit:WebKitGtk
>+AXPlatformAttributes: computed-role:paragraph, tag:p, toolkit:WebKitGtk
>diff --git a/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt b/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
>index 0aefe4e72bba23bd41188b46a950feeb9da20171..997fa26b9528d287f2c7e59779db5a3a0e9598de 100644
>--- a/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
>+++ b/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
>@@ -48,7 +48,7 @@ PASS: meter -> progressbar.
> PASS: nav -> navigation. 
> PASS: ol -> list. 
> PASS: li -> listitem. 
>-PASS: p -> . 
>+PASS: p -> paragraph. 
> PASS: pre -> . 
> PASS: progress -> progressbar. 
> PASS: samp -> . 
>@@ -99,7 +99,9 @@ PASS: div[role="alertdialog"] -> alertdialog.
> PASS: div[role="application"] -> application. 
> PASS: div[role="article"] -> article. 
> PASS: div[role="banner"] -> banner. 
>+PASS: div[role="blockquote"] -> blockquote. 
> PASS: div[role="button"] -> button. 
>+PASS: div[role="caption"] -> caption. 
> PASS: div[role="checkbox"] -> checkbox. 
> PASS: div[role="combobox"] -> combobox. 
> PASS: div[role="complementary"] -> complementary. 
>@@ -141,6 +143,7 @@ PASS: div[role="menuitemcheckbox"] -> menuitemcheckbox.
> PASS: div[role="menuitemradio"] -> menuitemradio. 
> PASS: div[role="navigation"] -> navigation. 
> PASS: div[role="note"] -> note. 
>+PASS: div[role="paragraph"] -> paragraph. 
> PASS: div[role="progressbar"] -> progressbar. 
> PASS: div[role="radiogroup"] -> radiogroup. 
> PASS: div[role="radio"] -> radio. 
>diff --git a/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt b/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
>index 35dcfe5746e645ccc21a000d026f27fb999a40ef..36453a12f873b3ca1f27f82eb53fe41abe34dd48 100644
>--- a/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
>+++ b/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
>@@ -834,11 +834,21 @@ div[role=banner]
>       AXSubrole: AXLandmarkBanner
>       AXRoleDescription: banner
>       
>+div[role=blockquote]
>+      AXRole: AXGroup
>+      AXSubrole: 
>+      AXRoleDescription: group
>+      
> div[role=button]
>       AXRole: AXButton
>       AXSubrole: 
>       AXRoleDescription: button
>       
>+div[role=caption]
>+      AXRole: AXGroup
>+      AXSubrole: 
>+      AXRoleDescription: group
>+      
> div[role=checkbox]
>       AXRole: AXCheckBox
>       AXSubrole: 
>@@ -1244,6 +1254,11 @@ div[role=note]
>       AXSubrole: AXDocumentNote
>       AXRoleDescription: note
>       
>+div[role=paragraph]
>+      AXRole: AXGroup
>+      AXSubrole: 
>+      AXRoleDescription: group
>+      
> div[role=presentation]
>       AXRole: 
>       AXSubrole:

Flags:

cfleizach: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186274: 341958 | 341961 | 341962 | 341963