Attachment 341948 Details for Bug 186296 – Patch

[patch] Patch

bug-186296-20180604192928.patch (text/plain), 2.82 KB, created by Timothy Hatcher on 2018-06-04 19:29:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-06-04 19:29:28 PDT

Size: 2.82 KB

patch

obsolete

>Subversion Revision: 232389
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 985e5b88c5f4a25e6f928b99063ec47ecab7ca9b..7a9ff08acfd3582d8473a9d7f19bd90f2e4ba04b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-04  Timothy Hatcher  <timothy@apple.com>
>+
>+        [Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments
>+        https://bugs.webkit.org/show_bug.cgi?id=186296
>+
>+        Unreviewed build fix.
>+
>+        * platform/win/PopupMenuWin.cpp:
>+        (WebCore::PopupMenuWin::paint):
>+        * rendering/RenderThemeWin.cpp:
>+        (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor const):
>+
> 2018-06-04  Timothy Hatcher  <timothy@apple.com>
> 
>         Selection color is dark when using Safari in dark mode.
>diff --git a/Source/WebCore/platform/win/PopupMenuWin.cpp b/Source/WebCore/platform/win/PopupMenuWin.cpp
>index f29406a97fa4132eb1303461b48ef47e34b069ef..02f099d9e25936ec6f01e73867440958de01ebbb 100644
>--- a/Source/WebCore/platform/win/PopupMenuWin.cpp
>+++ b/Source/WebCore/platform/win/PopupMenuWin.cpp
>@@ -621,8 +621,8 @@ void PopupMenuWin::paint(const IntRect& damageRect, HDC hdc)
>         Color optionBackgroundColor, optionTextColor;
>         PopupMenuStyle itemStyle = client()->itemStyle(index);
>         if (index == focusedIndex()) {
>-            optionBackgroundColor = RenderTheme::singleton().activeListBoxSelectionBackgroundColor();
>-            optionTextColor = RenderTheme::singleton().activeListBoxSelectionForegroundColor();
>+            optionBackgroundColor = RenderTheme::singleton().activeListBoxSelectionBackgroundColor({ });
>+            optionTextColor = RenderTheme::singleton().activeListBoxSelectionForegroundColor({ });
>         } else {
>             optionBackgroundColor = itemStyle.backgroundColor();
>             optionTextColor = itemStyle.foregroundColor();
>diff --git a/Source/WebCore/rendering/RenderThemeWin.cpp b/Source/WebCore/rendering/RenderThemeWin.cpp
>index f14a38e147b8302dd0b3c1689e96a34ad1728268..98cb15aabf387a2a7919bb08b70e8f87cc412d93 100644
>--- a/Source/WebCore/rendering/RenderThemeWin.cpp
>+++ b/Source/WebCore/rendering/RenderThemeWin.cpp
>@@ -311,9 +311,9 @@ Color RenderThemeWin::platformActiveSelectionForegroundColor(OptionSet<StyleColo
>     return Color(GetRValue(color), GetGValue(color), GetBValue(color));
> }
> 
>-Color RenderThemeWin::platformInactiveSelectionForegroundColor(OptionSet<StyleColor::Options>) const
>+Color RenderThemeWin::platformInactiveSelectionForegroundColor(OptionSet<StyleColor::Options> options) const
> {
>-    return platformActiveSelectionForegroundColor();
>+    return platformActiveSelectionForegroundColor(options);
> }
> 
> static void fillFontDescription(FontCascadeDescription& fontDescription, LOGFONT& logFont, float fontSize)

Actions: View | Formatted Diff | Diff

Attachments on bug 186296: 341947 | 341948