Attachment 341947 Details for Bug 186296 – Patch

[patch] Patch

bug-186296-20180604191824.patch (text/plain), 1.80 KB, created by Timothy Hatcher on 2018-06-04 19:18:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-06-04 19:18:24 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 232389
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 985e5b88c5f4a25e6f928b99063ec47ecab7ca9b..a4d22dac628e436987dcc442ae7d27c975ccbd56 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-04  Timothy Hatcher  <timothy@apple.com>
>+
>+        [Win] REGRESSION(r232486) 'WebCore::RenderTheme::activeListBoxSelectionBackgroundColor': function does not take 0 arguments
>+        https://bugs.webkit.org/show_bug.cgi?id=186296
>+
>+        Unreviewed build fix.
>+
>+        * platform/win/PopupMenuWin.cpp:
>+        (WebCore::PopupMenuWin::paint):
>+
> 2018-06-04  Timothy Hatcher  <timothy@apple.com>
> 
>         Selection color is dark when using Safari in dark mode.
>diff --git a/Source/WebCore/platform/win/PopupMenuWin.cpp b/Source/WebCore/platform/win/PopupMenuWin.cpp
>index f29406a97fa4132eb1303461b48ef47e34b069ef..02f099d9e25936ec6f01e73867440958de01ebbb 100644
>--- a/Source/WebCore/platform/win/PopupMenuWin.cpp
>+++ b/Source/WebCore/platform/win/PopupMenuWin.cpp
>@@ -621,8 +621,8 @@ void PopupMenuWin::paint(const IntRect& damageRect, HDC hdc)
>         Color optionBackgroundColor, optionTextColor;
>         PopupMenuStyle itemStyle = client()->itemStyle(index);
>         if (index == focusedIndex()) {
>-            optionBackgroundColor = RenderTheme::singleton().activeListBoxSelectionBackgroundColor();
>-            optionTextColor = RenderTheme::singleton().activeListBoxSelectionForegroundColor();
>+            optionBackgroundColor = RenderTheme::singleton().activeListBoxSelectionBackgroundColor({ });
>+            optionTextColor = RenderTheme::singleton().activeListBoxSelectionForegroundColor({ });
>         } else {
>             optionBackgroundColor = itemStyle.backgroundColor();
>             optionTextColor = itemStyle.foregroundColor();

Actions: View | Formatted Diff | Diff

Attachments on bug 186296: 341947 | 341948