Attachment 341934 Details for Bug 186290 – Patch

[patch] Patch

bug-186290-20180604161925.patch (text/plain), 1.71 KB, created by Daniel Bates on 2018-06-04 16:19:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-06-04 16:19:54 PDT

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 232483
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2fc4f37a91338e4b7c17e0efe577f8c68e37a94b..841c30d8dd1d33ddad3fb974bf254acdaafcf5bb 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-04  Daniel Bates  <dabates@apple.com>
>+
>+        Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
>+        https://bugs.webkit.org/show_bug.cgi?id=186290
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
>+        questionable we should fix a typo when calling this mocked function with argument since.
>+
>+        * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
>+        (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
>+
> 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
> 
>         Add Mojave support to WebKit tools
>diff --git a/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py b/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
>index fd889cdcdf7ab5c9c200981604cdc704e4b020c5..d117ff8e3f8b6b1d1a51c43123c0a5ba3026a97d 100644
>--- a/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
>+++ b/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
>@@ -297,7 +297,7 @@ class MockBugzillaQueries(object):
>         unreviewed_patches = sum([bug.unreviewed_patches()
>                                   for bug in self._all_bugs()], [])
>         if since:
>-            unreviewed_pacthes = [patch for patch in unreviewed_patches
>+            unreviewed_patches = [patch for patch in unreviewed_patches
>                                         if patch.attach_date() >= since]
>         return map(lambda patch: patch.id(), unreviewed_patches)
>

Flags:

aakash_jain: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186290: 341934