WebKit Bugzilla
Attachment 341919 Details for
Bug 186277
: JSLock should clear last exception when releasing the lock
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186277-20180604143742.patch (text/plain), 1.40 KB, created by
Keith Miller
on 2018-06-04 14:37:42 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Miller
Created:
2018-06-04 14:37:42 PDT
Size:
1.40 KB
patch
obsolete
>Subversion Revision: 232355 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 4551459e1a64e32fa74b7dfbac31741f32549048..1c46be533a069d45233f9e87a7f4d414ab257276 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-06-04 Keith Miller <keith_miller@apple.com> >+ >+ JSLock should clear last exception when releasing the lock >+ https://bugs.webkit.org/show_bug.cgi?id=186277 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ If we don't clear the last exception we essentially leak the >+ object and everything referenced by it until another exception is >+ thrown. >+ >+ * runtime/JSLock.cpp: >+ (JSC::JSLock::willReleaseLock): >+ > 2018-05-30 Yusuke Suzuki <utatane.tea@gmail.com> > > [JSC] Pass VM& parameter as much as possible >diff --git a/Source/JavaScriptCore/runtime/JSLock.cpp b/Source/JavaScriptCore/runtime/JSLock.cpp >index dfb75a7d01fc265db80a76bbe388b0f0ad7a6dca..51d1870fa2ce6da955394f884030735de6728a43 100644 >--- a/Source/JavaScriptCore/runtime/JSLock.cpp >+++ b/Source/JavaScriptCore/runtime/JSLock.cpp >@@ -199,6 +199,9 @@ void JSLock::willReleaseLock() > if (vm) { > vm->drainMicrotasks(); > >+ if (!vm->topCallFrame) >+ vm->clearLastException(); >+ > vm->heap.releaseDelayedReleasedObjects(); > vm->setStackPointerAtVMEntry(nullptr); >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mark.lam
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186277
:
341909
| 341919