WebKit Bugzilla
Attachment 341892 Details for
Bug 186259
: [MotionMark] Strip out more characters when creating permalinks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186259-20180603221229.patch (text/plain), 2.16 KB, created by
Jon Lee
on 2018-06-03 22:12:30 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jon Lee
Created:
2018-06-03 22:12:30 PDT
Size:
2.16 KB
patch
obsolete
>Subversion Revision: 232456 >diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog >index 83d67ab24b0fbd778449b8da4c94b09bea1916d6..6b1225169cdda4235ce10caece7e7b2f52974905 100644 >--- a/PerformanceTests/ChangeLog >+++ b/PerformanceTests/ChangeLog >@@ -1,3 +1,15 @@ >+2018-06-03 Jon Lee <jonlee@apple.com> >+ >+ Strip out more characters when creating permalinks >+ https://bugs.webkit.org/show_bug.cgi?id=186259 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * MotionMark/resources/debug-runner/motionmark.js: For existing links, decode the suite and >+ test names. >+ * MotionMark/resources/extensions.js: >+ (Utilities.stripNonASCIICharacters): When creating new links, remove -+() characters. >+ > 2018-06-03 Jon Lee <jonlee@apple.com> > > Allow the ramp controller to run tests that take less time than the initial ramp-up phase >diff --git a/PerformanceTests/MotionMark/resources/debug-runner/motionmark.js b/PerformanceTests/MotionMark/resources/debug-runner/motionmark.js >index 88b1c3de72a175b7166b9ce899e79582838effc7..fdf4e5efa63674468c653379dbb3e3580c98f407 100644 >--- a/PerformanceTests/MotionMark/resources/debug-runner/motionmark.js >+++ b/PerformanceTests/MotionMark/resources/debug-runner/motionmark.js >@@ -481,6 +481,9 @@ window.suitesManager = > > suitesFromQueryString: function(suiteName, testName) > { >+ suiteName = decodeURIComponent(suiteName); >+ testName = decodeURIComponent(testName); >+ > var suites = []; > var suiteRegExp = new RegExp(suiteName, "i"); > var testRegExp = new RegExp(testName, "i"); >diff --git a/PerformanceTests/MotionMark/resources/extensions.js b/PerformanceTests/MotionMark/resources/extensions.js >index 38c72d6c7a67f837777156e243a97d1c3da3ecf1..8dfc0e03bab443e6801783883b2cfc711f69e51e 100644 >--- a/PerformanceTests/MotionMark/resources/extensions.js >+++ b/PerformanceTests/MotionMark/resources/extensions.js >@@ -149,7 +149,7 @@ Utilities = > > stripNonASCIICharacters: function(inputString) > { >- return inputString.replace(/[ .,]/g, ''); >+ return inputString.replace(/[ .,\-\+\(\)]/g, ''); > }, > > convertObjectToQueryString: function(object)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186259
:
341892
|
341925
|
342054