Attachment 341889 Details for Bug 186257 – Patch

[patch] Patch

bug-186257-20180603215020.patch (text/plain), 2.82 KB, created by Jon Lee on 2018-06-03 21:50:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jon Lee

Created: 2018-06-03 21:50:22 PDT

Size: 2.82 KB

patch

obsolete

>Subversion Revision: 232456
>diff --git a/PerformanceTests/ChangeLog b/PerformanceTests/ChangeLog
>index 01bf7c1c52cb122f438fcf6385b3f7e1157045e2..83d67ab24b0fbd778449b8da4c94b09bea1916d6 100644
>--- a/PerformanceTests/ChangeLog
>+++ b/PerformanceTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-03  Jon Lee  <jonlee@apple.com>
>+
>+        Allow the ramp controller to run tests that take less time than the initial ramp-up phase
>+        https://bugs.webkit.org/show_bug.cgi?id=186257
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * MotionMark/tests/resources/main.js: Extend the desired end timestamp when ramp-up occurs.
>+        Previously the controller assumed that the duration of the test was always longer than the
>+        time it took to figure out the order of magnitude of particles to render. When that range
>+        is determined, the end timestamp is then extended. If the duration is too short, the controller
>+        would throw an exception. The fix is to continue extending the timestamp every time the order of
>+        magnitude tiers up.
>+                In general testing with really short durations isn't practical, but sometimes it is
>+        desired for debugging.
>+
> 2018-06-03  Jon Lee  <jonlee@apple.com>
> 
>         Remove unneeded data processing in MotionMark
>diff --git a/PerformanceTests/MotionMark/tests/resources/main.js b/PerformanceTests/MotionMark/tests/resources/main.js
>index bfeefdfe04d4673079f58fb1dd21853e01001706..11178f41ccb5324b5131b0221807b10bfd322c5f 100644
>--- a/PerformanceTests/MotionMark/tests/resources/main.js
>+++ b/PerformanceTests/MotionMark/tests/resources/main.js
>@@ -314,6 +314,8 @@ RampController = Utilities.createSubclass(Controller,
>         this._minimumComplexity = 1;
>         this._maximumComplexity = 1;
> 
>+        this._testLength = options["test-interval"];
>+
>         // After the tier range is determined, figure out the number of ramp iterations
>         var minimumRampLength = 3000;
>         var totalRampIterations = Math.max(1, Math.floor(this._endTimestamp / minimumRampLength));
>@@ -377,6 +379,7 @@ RampController = Utilities.createSubclass(Controller,
>                 this._lastTierFrameLength = currentFrameLength;
> 
>                 this._tier += .5;
>+                this._endTimestamp = timestamp + this._testLength;
>                 var nextTierComplexity = Math.round(Math.pow(10, this._tier));
>                 stage.tune(nextTierComplexity - currentComplexity);
> 
>@@ -394,7 +397,7 @@ RampController = Utilities.createSubclass(Controller,
>             this.intervalSamplingLength = 120;
> 
>             // Extend the test length so that the full test length is made of the ramps
>-            this._endTimestamp += timestamp;
>+            this._endTimestamp = timestamp + this._testLength;
>             this.mark(Strings.json.samplingStartTimeOffset, timestamp);
> 
>             this._minimumComplexity = 1;

Actions: View | Formatted Diff | Diff

Attachments on bug 186257: 341889 | 342082