Attachment 341819 Details for Bug 186220 – Patch

[patch] Patch

bug-186220-20180601194738.patch (text/plain), 1.71 KB, created by Eric Carlson on 2018-06-01 19:47:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2018-06-01 19:47:38 PDT

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 232399
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ff60d3759cdc1236638e66a7ac7578cc06904e6c..59f82481ef287e078db3f3e1518f91a3e8656362 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-01  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [iOS] MediaPlayer.framework is not always available
>+        https://bugs.webkit.org/show_bug.cgi?id=186220
>+        <rdar://problem/40571286>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios/RemoteCommandListenerIOS.mm:
>+        (WebCore::RemoteCommandListener::create):
>+
> 2018-06-01  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Simplify the formatting class implementation by pushing down some of the logic to the Geometry class
>diff --git a/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm b/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm
>index 9a96491cd1b69febd7f0f8da56be0ec283b02cb0..35ef1cf24fc71c58bb5b7cdfca58f5a03bf8ee6c 100644
>--- a/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm
>+++ b/Source/WebCore/platform/ios/RemoteCommandListenerIOS.mm
>@@ -33,7 +33,7 @@
> #import <MediaPlayer/MPRemoteCommandEvent.h>
> #import <wtf/SoftLinking.h>
> 
>-SOFT_LINK_FRAMEWORK(MediaPlayer)
>+SOFT_LINK_FRAMEWORK_OPTIONAL(MediaPlayer)
> SOFT_LINK_CLASS(MediaPlayer, MPRemoteCommandCenter)
> SOFT_LINK_CLASS(MediaPlayer, MPSeekCommandEvent)
> SOFT_LINK_CLASS(MediaPlayer, MPChangePlaybackPositionCommandEvent)
>@@ -42,6 +42,9 @@ namespace WebCore {
> 
> std::unique_ptr<RemoteCommandListener> RemoteCommandListener::create(RemoteCommandListenerClient& client)
> {
>+    if (!MediaPlayerLibrary())
>+        return nullptr;
>+
>     return std::make_unique<RemoteCommandListenerIOS>(client);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186220: 341819