Attachment 341804 Details for Bug 186058 – Patch

[patch] Patch

bug-186058-20180601164439.patch (text/plain), 1.43 KB, created by Jeremy Jones on 2018-06-01 16:44:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-06-01 16:44:40 PDT

Size: 1.43 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3abbd15888ee227cd2c267ff839bc3e1edee6bea..77d13c0d624e85e8c9acbf6eabd3db14498b2975 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-05-29  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Disable keyboard in fullscreen ios.
>+        https://bugs.webkit.org/show_bug.cgi?id=186058
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Disallow keyboard in ios fullscreen. This will still allow select keys useful for playback.
>+
>+        * UIProcess/WebFullScreenManagerProxy.cpp:
>+        (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
>+
> 2018-05-18  Brian Burg  <bburg@apple.com>
> 
>         [Cocoa] Add missing nullability annotations to _WKAutomationSessionDelegate
>diff --git a/Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp b/Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
>index f5818c64d71b368863a4e36f6740197d1d5a05aa..a0d8cdbeb2f01efe996134c61a97afb0e6e4db0e 100644
>--- a/Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
>@@ -103,7 +103,11 @@ void WebFullScreenManagerProxy::requestExitFullScreen()
> 
> void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)
> {
>+#if PLATFORM(IOS)
>+    supports = !withKeyboard;
>+#else
>     supports = true;
>+#endif
> }
> 
> void WebFullScreenManagerProxy::saveScrollPosition()

Actions: View | Formatted Diff | Diff

Attachments on bug 186058: 341509 | 341804 | 341816