Attachment 341683 Details for Bug 186137 – Patch

[patch] Patch

bug-186137-20180531120619.patch (text/plain), 4.80 KB, created by Daniel Bates on 2018-05-31 12:06:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-05-31 12:06:28 PDT

Size: 4.80 KB

patch

obsolete

>Subversion Revision: 232357
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 116758731de314f9ee91c3894183e9e2dff7c63b..7d2d695d14d9c7b68729d3ee7c33bee1a6bb0ed3 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-31  Daniel Bates  <dabates@apple.com>
>+
>+        http/tests/inspector/network/har/har-page.html should actually sort dumped cookies by name
>+        https://bugs.webkit.org/show_bug.cgi?id=186137
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        JavaScript does not support comparison of String data types using the minus operator. Instead
>+        implement the string comparator using relational operators and the identity operator.
>+
>+        * http/tests/inspector/network/har/har-page-expected.txt:
>+        * http/tests/inspector/network/har/har-page.html:
>+
> 2018-05-31  Chris Dumez  <cdumez@apple.com>
> 
>         Update http/wpt/service-workers/header-filtering.https.html to use a valid Referrer-Policy
>diff --git a/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt b/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt
>index b0dc45a97245d999d2745b64424d97ac2adb5cde..3d05c990cc7b457ebb289d98fe277882861d0878 100644
>--- a/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt
>+++ b/LayoutTests/http/tests/inspector/network/har/har-page-expected.txt
>@@ -539,6 +539,10 @@ HAR Page Test.
>               "name": "http-only",
>               "value": "http-only"
>             },
>+            {
>+              "name": "same-site-strict",
>+              "value": "same-site-strict"
>+            },
>             {
>               "name": "simple",
>               "value": "simple"
>@@ -546,10 +550,6 @@ HAR Page Test.
>             {
>               "name": "with-expiration",
>               "value": "with-expiration"
>-            },
>-            {
>-              "name": "same-site-strict",
>-              "value": "same-site-strict"
>             }
>           ],
>           "headers": "<filtered>",
>@@ -606,14 +606,6 @@ HAR Page Test.
>               "name": "http-only",
>               "value": "http-only"
>             },
>-            {
>-              "name": "simple",
>-              "value": "simple"
>-            },
>-            {
>-              "name": "with-expiration",
>-              "value": "with-expiration"
>-            },
>             {
>               "name": "same-site-implicit-strict",
>               "value": "same-site-implicit-strict"
>@@ -621,6 +613,14 @@ HAR Page Test.
>             {
>               "name": "same-site-strict",
>               "value": "same-site-strict"
>+            },
>+            {
>+              "name": "simple",
>+              "value": "simple"
>+            },
>+            {
>+              "name": "with-expiration",
>+              "value": "with-expiration"
>             }
>           ],
>           "headers": "<filtered>",
>@@ -677,14 +677,6 @@ HAR Page Test.
>               "name": "http-only",
>               "value": "http-only"
>             },
>-            {
>-              "name": "simple",
>-              "value": "simple"
>-            },
>-            {
>-              "name": "with-expiration",
>-              "value": "with-expiration"
>-            },
>             {
>               "name": "same-site-implicit-strict",
>               "value": "same-site-implicit-strict"
>@@ -696,6 +688,14 @@ HAR Page Test.
>             {
>               "name": "same-site-strict-because-invalid-SameSite-value",
>               "value": "same-site-strict-because-invalid-SameSite-value"
>+            },
>+            {
>+              "name": "simple",
>+              "value": "simple"
>+            },
>+            {
>+              "name": "with-expiration",
>+              "value": "with-expiration"
>             }
>           ],
>           "headers": "<filtered>",
>diff --git a/LayoutTests/http/tests/inspector/network/har/har-page.html b/LayoutTests/http/tests/inspector/network/har/har-page.html
>index 2258c5728f4c6f0634d94fc08da4d3775dbacac5..7c04d6b5dfd116c229ce1dd9b59861413612127d 100644
>--- a/LayoutTests/http/tests/inspector/network/har/har-page.html
>+++ b/LayoutTests/http/tests/inspector/network/har/har-page.html
>@@ -50,9 +50,12 @@ function test()
>             return "<filtered>";
>         }
> 
>-        // Sort cookies by name to make cookie order deterministic between test runs.
>-        if (key === "cookies")
>-            value.sort((a, b) => { return a.name - b.name; });
>+        // Sort cookies by name to make cookie order deterministic between test runs. We assume
>+        // that cookies have names that consist of only ASCII characters.
>+        if (key === "cookies") {
>+            value.sort((a, b) => { return a.name === b.name ? 0 : (a.name < b.name ? -1 : 1); });
>+            return value;
>+        }
> 
>         // Since cache may or may not be used, timing data may be variable.
>         // NOTE: SSL should always be -1 for this test case.

Flags:

joepeck: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 186137: 341683 | 341753