WebKit Bugzilla
Attachment 341669 Details for
Bug 186149
: REGRESSION (r229935): Memory leak under NetworkStateNotifier::updateStateWithoutNotifying()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186149-20180531100407.patch (text/plain), 1.58 KB, created by
Chris Dumez
on 2018-05-31 10:04:08 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2018-05-31 10:04:08 PDT
Size:
1.58 KB
patch
obsolete
>Subversion Revision: 232348 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 05273ba576e0f432c3c8f2a2d7168592e2a54e86..f445bb5a5a7686619c5db349aea583fdd45328bd 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,14 @@ >+2018-05-31 Chris Dumez <cdumez@apple.com> >+ >+ Fix memory leak under NetworkStateNotifier::updateStateWithoutNotifying() >+ https://bugs.webkit.org/show_bug.cgi?id=186149 >+ <rdar://problem/40674537> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * platform/network/mac/NetworkStateNotifierMac.cpp: >+ (WebCore::NetworkStateNotifier::updateStateWithoutNotifying): >+ > 2018-05-31 Chris Dumez <cdumez@apple.com> > > Unreviewed, apply review comments from Darin after r232310. >diff --git a/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp b/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp >index b1b76003f1ee09a4387a5538847c1fa06aa3355c..86c7929b870f4de9c3e1615b15a2feb4f4390d0e 100644 >--- a/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp >+++ b/Source/WebCore/platform/network/mac/NetworkStateNotifierMac.cpp >@@ -61,7 +61,7 @@ void NetworkStateNotifier::updateStateWithoutNotifying() > continue; > > auto key = adoptCF(SCDynamicStoreKeyCreateNetworkInterfaceEntity(0, kSCDynamicStoreDomainState, interfaceName, kSCEntNetIPv4)); >- if (SCDynamicStoreCopyValue(m_store.get(), key.get())) { >+ if (auto value = adoptCF(SCDynamicStoreCopyValue(m_store.get(), key.get()))) { > m_isOnLine = true; > return; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186149
: 341669