WebKit Bugzilla
Attachment 341640 Details for
Bug 186124
: [LFC] Margin box is border box + margins.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186124-20180530194219.patch (text/plain), 1.62 KB, created by
zalan
on 2018-05-30 19:42:20 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
zalan
Created:
2018-05-30 19:42:20 PDT
Size:
1.62 KB
patch
obsolete
>Subversion Revision: 232291 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index e6b63ec7c0870b927d492af14f7c2677878e9eed..f00d998a5251703334dc451815b3bd408f7a1588 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,13 @@ >+2018-05-30 Zalan Bujtas <zalan@apple.com> >+ >+ [LFC] Margin box is border box + margins. >+ https://bugs.webkit.org/show_bug.cgi?id=186124 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * layout/displaytree/DisplayBox.cpp: >+ (WebCore::Display::Box::marginBox const): >+ > 2018-05-30 Zalan Bujtas <zalan@apple.com> > > [LFC] Miscellaneous fixes to get closer to geometry correctness >diff --git a/Source/WebCore/layout/displaytree/DisplayBox.cpp b/Source/WebCore/layout/displaytree/DisplayBox.cpp >index d0c8b9e40f161f62a97ae17f0a55e3ce2aa57abd..df22d8fc44f29b8fb25bf9c419bc853dd37849d5 100644 >--- a/Source/WebCore/layout/displaytree/DisplayBox.cpp >+++ b/Source/WebCore/layout/displaytree/DisplayBox.cpp >@@ -55,10 +55,10 @@ Box::Rect Box::marginBox() const > ASSERT(m_hasValidMargin); > auto marginBox = borderBox(); > >- marginBox.shiftLeftTo(marginBox.left() + m_margin.left); >- marginBox.shiftTopTo(marginBox.top() + m_margin.top); >- marginBox.shiftRightTo(marginBox.right() - m_margin.right); >- marginBox.shiftBottomTo(marginBox.bottom() - m_margin.bottom); >+ marginBox.shiftLeftTo(marginBox.left() - m_margin.left); >+ marginBox.shiftTopTo(marginBox.top() - m_margin.top); >+ marginBox.shiftRightTo(marginBox.right() + m_margin.right); >+ marginBox.shiftBottomTo(marginBox.bottom() + m_margin.bottom); > > return marginBox; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186124
: 341640