Attachment 341633 Details for Bug 186115 – Patch

[patch] Patch

bug-186115-20180530213911.patch (text/plain), 2.96 KB, created by Leo Balter on 2018-05-30 18:39:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-05-30 18:39:12 PDT

Size: 2.96 KB

patch

obsolete

>Subversion Revision: 232320
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 4d0b8d94ff46e978bec1460bbd8e32b0c9f34fac..600f69f30ec0e40fd609419f177d19ae15ae1203 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-30  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        test262-runner should run in verbose mode in automation
>+        https://bugs.webkit.org/show_bug.cgi?id=186115
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch toggles the verbose mode in the build bot and reports a simple dot for each passing test
>+        in order to avoid the '1200 seconds without output' issue.
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (RunTest262Tests):
>+        * Scripts/test262/Runner.pm:
>+        (processResult):
>+
> 2018-05-30  Youenn Fablet  <youenn@apple.com>
> 
>         Rename CrossOriginResourcePolicy same to same-origin
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index a78473370de63b6b3dae5ba0f859c53eeb1144d8..0631e86e3c55d84c0505af6985756e90a53d5ff1 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -367,7 +367,7 @@ class RunTest262Tests(TestWithFailureCount):
>     description = ["test262-tests running"]
>     descriptionDone = ["test262-tests"]
>     failedTestsFormatString = "%d Test262 test%s failed"
>-    command = ["perl", "./Tools/Scripts/test262-runner", WithProperties("--%(configuration)s")]
>+    command = ["perl", "./Tools/Scripts/test262-runner", "--verbose", WithProperties("--%(configuration)s")]
> 
>     def start(self):
>         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index ec30d01fd4cd58365d2ba0cac2e3156d2959b619..aaebe6790b3e90feaf87957265e54d561dcfc717 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -678,22 +678,25 @@ sub processResult {
>         my $failMsg = '';
>         $failMsg = "FAIL $file ($scenario)\n" if ($printFailure or $verbose);
> 
>+        my $prefixMsg = '';
>         my $suffixMsg = '';
> 
>         if ($verbose) {
>+            $prefixMsg = "\n";
>             my $featuresList = '';
>             $featuresList = "\nFeatures: " . join(', ', @{ $data->{features} }) if $data->{features};
>             $suffixMsg = "$result$featuresList\n\n";
>         }
> 
>-        print "$newFail$failMsg$suffixMsg";
>+        print "$prefixMsg$newFail$failMsg$suffixMsg";
> 
>         $resultdata{result} = 'FAIL';
>         $resultdata{error} = $currentfailure;
>     } elsif ($scenario ne 'skip' && !$currentfailure) {
>         if ($expectedfailure) {
>-            print "NEW PASS $file ($scenario)\n";
>-            print "\n" if $verbose;
>+            print "\nNEW PASS $file ($scenario)\n";
>+        } elsif ($verbose) {
>+            print '.';
>         }
> 
>         $resultdata{result} = 'PASS';

Actions: View | Formatted Diff | Diff

Attachments on bug 186115: 341633 | 341636