Attachment 341629 Details for Bug 186121 – patch

[patch] patch

b-backup.diff (text/plain), 3.44 KB, created by Saam Barati on 2018-05-30 18:15:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-05-30 18:15:47 PDT

Size: 3.44 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 232325)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-30  Saam Barati  <sbarati@apple.com>
>+
>+        DFG combined liveness needs to say that the machine CodeBlock's arguments are live
>+        https://bugs.webkit.org/show_bug.cgi?id=186121
>+        <rdar://problem/39377796>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/combined-liveness-needs-to-say-arguments-are-live.js: Added.
>+        (baz):
>+        (foo):
>+
> 2018-05-30  Keith Miller  <keith_miller@apple.com>
> 
>         Unreviewed, uncomment erroneously commented test code.
>Index: JSTests/stress/combined-liveness-needs-to-say-arguments-are-live.js
>===================================================================
>--- JSTests/stress/combined-liveness-needs-to-say-arguments-are-live.js	(nonexistent)
>+++ JSTests/stress/combined-liveness-needs-to-say-arguments-are-live.js	(working copy)
>@@ -0,0 +1,24 @@
>+//@ runDefault("--jitPolicyScale=0", "--validateFTLOSRExitLiveness=1", "--useConcurrentJIT=0")
>+
>+// This should not crash in liveness validation.
>+
>+function baz() { }
>+noInline(baz);
>+
>+function foo() {
>+    let i, j;
>+    let a0 = [0, 1];
>+    let a1 = [];
>+    for (i = 0; i < a0.length; i++) {
>+        a1.push();
>+        for (j = 0; j < 6; j++) {
>+        }
>+        for (j = 0; j < 4; j++) {
>+            baz();
>+        }
>+    }
>+    throw new Error();
>+}
>+try {
>+    new foo();
>+} catch { }
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232325)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2018-05-30  Saam Barati  <sbarati@apple.com>
>+
>+        DFG combined liveness needs to say that the machine CodeBlock's arguments are live
>+        https://bugs.webkit.org/show_bug.cgi?id=186121
>+        <rdar://problem/39377796>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        DFG's combined liveness was reporting that the machine CodeBlock's |this|
>+        argument was dead at certain points in the program. However, a CodeBlock's
>+        arguments are considered live for the entire function. This fixes a bug
>+        where object allocation sinking phase skipped materializing an allocation
>+        because it thought that the argument it was associated with, |this|, was dead.
>+
>+        * dfg/DFGCombinedLiveness.cpp:
>+        (JSC::DFG::liveNodesAtHead):
>+
> 2018-05-30  Daniel Bates  <dabates@apple.com>
> 
>         Web Inspector: Annotate Same-Site cookies
>Index: Source/JavaScriptCore/dfg/DFGCombinedLiveness.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGCombinedLiveness.cpp	(revision 232325)
>+++ Source/JavaScriptCore/dfg/DFGCombinedLiveness.cpp	(working copy)
>@@ -1,5 +1,5 @@
> /*
>- * Copyright (C) 2015-2016 Apple Inc. All rights reserved.
>+ * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
>  *
>  * Redistribution and use in source and binary forms, with or without
>  * modification, are permitted provided that the following conditions
>@@ -44,7 +44,7 @@ NodeSet liveNodesAtHead(Graph& graph, Ba
>     }
>     
>     AvailabilityMap& availabilityMap = block->ssa->availabilityAtHead;
>-    graph.forAllLocalsLiveInBytecode(
>+    graph.forAllLiveInBytecode(
>         block->at(0)->origin.forExit,
>         [&] (VirtualRegister reg) {
>             availabilityMap.closeStartingWithLocal(

Actions: View | Formatted Diff | Diff

Attachments on bug 186121: 341629