Attachment 341585 Details for Bug 186103 – Patch v2

[patch] Patch v2

bug-186103-20180530112127.patch (text/plain), 2.00 KB, created by David Kilzer (:ddkilzer) on 2018-05-30 11:21:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-05-30 11:21:28 PDT

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 232301
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5abe2d28915408d0893fea1211e31dd1ff9e54d0..1bdd1cd80a8ea0019d103c388a57e5b286cfcf12 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-30  David Kilzer  <ddkilzer@apple.com>
>+
>+        [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppeear:]
>+        <https://webkit.org/b/186103>
>+        <rdar://problem/40655695>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
>+        (WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
>+        Drive-by clean up.  For consistency, we always use the same
>+        variable in the body of the `if` statement that was used in the
>+        condition.
>+        (-[WKFullScreenViewController viewWillAppear:]): Call
>+        [super viewWillAppeear:] to fulfill API contract.
>+
> 2018-05-30  Jer Noble  <jer.noble@apple.com>
> 
>         Auto-pip should use main content heuristic.
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>index 6bc452db3a6cbc51b43fd379efdcdeaf995ea0be..06c083ed5856eada841cbefa059e2676d8e1fa94 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>@@ -70,7 +70,7 @@ public:
>             m_interface->playbackSessionModel()->removeClient(*this);
>         m_interface = interface;
>         if (m_interface && m_interface->playbackSessionModel())
>-            interface->playbackSessionModel()->addClient(*this);
>+            m_interface->playbackSessionModel()->addClient(*this);
>     }
> 
> private:
>@@ -303,6 +303,8 @@ - (void)viewWillAppear:(BOOL)animated
> 
>     if (auto* manager = self._manager)
>         manager->setFullscreenAutoHideDelay(autoHideDelay);
>+
>+    [super viewWillAppear:animated];
> }
> 
> - (void)viewDidLayoutSubviews

Actions: View | Formatted Diff | Diff

Attachments on bug 186103: 341584 | 341585