Attachment 341584 Details for Bug 186103 – Patch v1

[patch] Patch v1

bug-186103-20180530111026.patch (text/plain), 2.25 KB, created by David Kilzer (:ddkilzer) on 2018-05-30 11:10:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-05-30 11:10:27 PDT

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 232275
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 64188cc3468c0f76d38cd1cd1b897aac8d5bee04..10d2bdbd96603083a03007a55a4b1365b596f7d1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-30  David Kilzer  <ddkilzer@apple.com>
>+
>+        Fix static analyzer warnings in WKFullScreenViewController.mm
>+        <https://webkit.org/b/186103>
>+        <rdar://problem/40655695>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
>+        (WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
>+        Prevent nullptr dereference crash when calling setInterface(nullptr)
>+        from -[WKFullScreenViewController dealloc].  For consistency, we
>+        always use the same variable in the body of the `if` statement
>+        that was used in the condition.
>+        (-[WKFullScreenViewController viewWillAppear:]): Call
>+        [super viewWillAppeear:] to fulfill API contract.
>+
> 2018-05-29  David Kilzer  <ddkilzer@apple.com>
> 
>         [iOS] Add assert to catch improper use of WebCore::Timer in UI Process
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>index 6710ae062b5b129de9056cbfd9217746a86fe707..dd4bfaa33d0cbd38a49b6c3b8ac4ff30c2be9017 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>@@ -67,10 +67,10 @@ public:
>             return;
> 
>         if (m_interface && m_interface->playbackSessionModel())
>-            interface->playbackSessionModel()->removeClient(*this);
>+            m_interface->playbackSessionModel()->removeClient(*this);
>         m_interface = interface;
>         if (m_interface && m_interface->playbackSessionModel())
>-            interface->playbackSessionModel()->addClient(*this);
>+            m_interface->playbackSessionModel()->addClient(*this);
>     }
> 
> private:
>@@ -303,6 +303,8 @@ - (void)viewWillAppear:(BOOL)animated
> 
>     if (auto* manager = self._manager)
>         manager->setFullscreenAutoHideDelay(autoHideDelay);
>+
>+    [super viewWillAppear:animated];
> }
> 
> - (void)viewDidLayoutSubviews

Actions: View | Formatted Diff | Diff

Attachments on bug 186103: 341584 | 341585