Attachment 341575 Details for Bug 186097 – Patch

[patch] Patch

bug-186097-20180530084844.patch (text/plain), 1.69 KB, created by Chris Dumez on 2018-05-30 08:48:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-30 08:48:42 PDT

Size: 1.69 KB

patch

obsolete

>Subversion Revision: 232257
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1c12d7c09b521f2727d699238f934a2ed6112c7f..f3887766515fa92bc7e6b9aa4be8aef20db341e8 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-30  Chris Dumez  <cdumez@apple.com>
>+
>+        Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate()
>+        https://bugs.webkit.org/show_bug.cgi?id=186097
>+        <rdar://problem/40651225>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate(). Otherwise,
>+        apps may get stuck on _doAfterNextPresentationUpdate because the WebProcess got suspended.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::callAfterNextPresentationUpdate):
>+
> 2018-05-28  Sam Weinig  <sam@webkit.org>
> 
>         Modernize SVGRenderStyleDefs.h
>diff --git a/Source/WebKit/UIProcess/WebPageProxy.cpp b/Source/WebKit/UIProcess/WebPageProxy.cpp
>index ea43629501c59f2b34f4fbb0be6b740120c08991..0dbd01fd55ba352277787a68238d6dd75338e06a 100644
>--- a/Source/WebKit/UIProcess/WebPageProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebPageProxy.cpp
>@@ -7351,7 +7351,9 @@ void WebPageProxy::callAfterNextPresentationUpdate(WTF::Function<void (CallbackB
>         return;
>     }
> 
>-    m_drawingArea->dispatchAfterEnsuringDrawing(WTFMove(callback));
>+    m_drawingArea->dispatchAfterEnsuringDrawing([callback = WTFMove(callback), backgroundActivity = m_process->throttler().backgroundActivityToken()](CallbackBase::Error error) {
>+        callback(error);
>+    });
> }
> 
> void WebPageProxy::setShouldScaleViewToFitDocument(bool shouldScaleViewToFitDocument)

Actions: View | Formatted Diff | Diff

Attachments on bug 186097: 341575 | 341594