Attachment 341570 Details for Bug 186093 – Patch

[patch] Patch

bug-186093-20180530073320.patch (text/plain), 1.96 KB, created by Jeremy Jones on 2018-05-30 07:33:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-30 07:33:21 PDT

Size: 1.96 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ef77cb83859a3bc9b332867e0a88dea75276f71a..0814162cfeb7b283306a1c7ee903dafb00fe5e85 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-05-30  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Enable video controls when in element fullscreen.
>+        https://bugs.webkit.org/show_bug.cgi?id=186093
>+        rdar://problem/40144751
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Enable media controls when the media element is in element fullscreen.
>+
>+        * Modules/modern-media-controls/media/media-controller.js:
>+        (MediaController.prototype._shouldControlsBeAvailable):
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/Source/WebCore/Modules/modern-media-controls/media/media-controller.js b/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>index 18fa91eb93049bd02ea6dc46755e60672da4dfc3..0a5da830c0bbf6f25e7927ccb53916624fcb650f 100644
>--- a/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>+++ b/Source/WebCore/Modules/modern-media-controls/media/media-controller.js
>@@ -324,9 +324,9 @@ class MediaController
>         if (this.layoutTraits & LayoutTraits.Compact)
>             return true;
> 
>-        // Controls are always available while in fullscreen on macOS, and they are never available when in fullscreen on iOS.
>+        // Controls are always available while in fullscreen on macOS, and on iOS for element fullscreen.
>         if (this.isFullscreen)
>-            return !!(this.layoutTraits & LayoutTraits.macOS);
>+            return !!(this.layoutTraits & LayoutTraits.macOS) || (document.webkitCurrentFullScreenElement === this.media);
> 
>         // Otherwise, for controls to be available, the controls attribute must be present on the media element
>         // or the MediaControlsHost must indicate that controls are forced.

Actions: View | Formatted Diff | Diff

Attachments on bug 186093: 341570 | 341606 | 343820 | 343823 | 343843 | 344473 | 344497