Attachment 341564 Details for Bug 186089 – Patch

[patch] Patch

bug-186089-20180530054359.patch (text/plain), 1.90 KB, created by Jeremy Jones on 2018-05-30 05:44:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-30 05:44:00 PDT

Size: 1.90 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ef77cb83859a3bc9b332867e0a88dea75276f71a..89bbfe7f90c4fb457cfff31722208546c399e9a4 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-05-30  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Don't continue playing in background when auto-picture-in-picture is disabled.
>+        https://bugs.webkit.org/show_bug.cgi?id=186089
>+        rdar://problem/40314314
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests because we don't have a way to test auto-pip.
>+
>+        With the refactoring work done in VideoFullscreenInterfaceAVKit, HTMLMediaElement no longer has to anticipate 
>+        auto-pip when if it should pause on suspend. Instead VideoFullscreenInterfaceAVKit proactively updates 
>+        videoFullscreenMode, so checking for PIP is sufficient.
>+
>+        * html/HTMLMediaElement.cpp:
>+        (WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/Source/WebCore/html/HTMLMediaElement.cpp b/Source/WebCore/html/HTMLMediaElement.cpp
>index 6c6ee240fafa673021a273b4afcca8917bb9eff7..de27392e885480630727ae7bff3cf2165773a507 100644
>--- a/Source/WebCore/html/HTMLMediaElement.cpp
>+++ b/Source/WebCore/html/HTMLMediaElement.cpp
>@@ -7532,7 +7532,7 @@ bool HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction(PlatformMedia
> #endif
>         if (m_videoFullscreenMode & VideoFullscreenModePictureInPicture)
>             return true;
>-#if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
>+#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
>         if (((m_videoFullscreenMode == VideoFullscreenModeStandard) || m_videoFullscreenStandby) && supportsPictureInPicture() && isPlaying())
>             return true;
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 186089: 341564