WebKit Bugzilla
Attachment 341561 Details for
Bug 186088
: Make WKWebView firstResponder after entering or exiting fullscreen.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186088-20180530043151.patch (text/plain), 2.04 KB, created by
Jeremy Jones
on 2018-05-30 04:31:51 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jeremy Jones
Created:
2018-05-30 04:31:51 PDT
Size:
2.04 KB
patch
obsolete
>Subversion Revision: 231991 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 3abbd15888ee227cd2c267ff839bc3e1edee6bea..c89d3c5ad5954e10a4eb8e4f2998cc57f4a87da2 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2018-05-30 Jeremy Jones <jeremyj@apple.com> >+ >+ Make WKWebView firstResponder after entering or exiting fullscreen. >+ https://bugs.webkit.org/show_bug.cgi?id=186088 >+ rdar://problem/40387859 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Update first responder when WKWebView moves to a new window, otherwise there won't be a first responder. >+ >+ * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: >+ (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): >+ (-[WKFullScreenWindowController _completedExitFullScreen]): >+ > 2018-05-18 Brian Burg <bburg@apple.com> > > [Cocoa] Add missing nullability annotations to _WKAutomationSessionDelegate >diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm >index d2f5f18ddb63b5af5b6791e7d4085fd2c75043ff..3ffe258bc17ab7321d4a08d67ea92274a1761ace 100644 >--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm >+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm >@@ -535,6 +535,7 @@ - (void)beganEnterFullScreenWithInitialFrame:(CGRect)initialFrame finalFrame:(CG > auto* page = [self._webView _page]; > auto* manager = self._manager; > if (page && manager) { >+ [webView becomeFirstResponder]; > manager->didEnterFullScreen(); > manager->setAnimatingFullScreen(false); > page->setSuppressVisibilityUpdates(false); >@@ -618,6 +619,7 @@ - (void)_completedExitFullScreen > [webView setAutoresizingMask:[_webViewPlaceholder autoresizingMask]]; > > [[webView window] makeKeyAndVisible]; >+ [webView becomeFirstResponder]; > > _viewState.applyTo(webView.get()); >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186088
:
341561
|
341806