Attachment 341546 Details for Bug 180866 – patch

[patch] patch

patch.txt (text/plain), 4.24 KB, created by Nan Wang on 2018-05-29 18:34:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nan Wang

Created: 2018-05-29 18:34:46 PDT

Size: 4.24 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 232283)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-05-29  Nan Wang  <n_wang@apple.com>
>+
>+        AX: macOS VoiceOver doesn't announce when details element is expanded when using role group
>+        https://bugs.webkit.org/show_bug.cgi?id=180866
>+        <rdar://problem/36074338>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should use is<HTMLDetailsElement> to check for the details parent instead
>+        of using the role.
>+
>+        Added test cases to the existing test.
>+
>+        * accessibility/AccessibilityObject.cpp:
>+        (WebCore::AccessibilityObject::isExpanded const):
>+
> 2018-05-29  Youenn Fablet  <youenn@apple.com>
> 
>         Add a consistency check between URL and CFURL
>Index: Source/WebCore/accessibility/AccessibilityObject.cpp
>===================================================================
>--- Source/WebCore/accessibility/AccessibilityObject.cpp	(revision 232259)
>+++ Source/WebCore/accessibility/AccessibilityObject.cpp	(working copy)
>@@ -2797,7 +2797,7 @@ bool AccessibilityObject::isExpanded() c
>     // Summary element should use its details parent's expanded status.
>     if (isSummary()) {
>         if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*this, false, [] (const AccessibilityObject& object) {
>-            return object.roleValue() == AccessibilityRole::Details;
>+            return object.node() && is<HTMLDetailsElement>(object.node());
>         }))
>             return parent->isExpanded();
>     }
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 232259)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-05-29  Nan Wang  <n_wang@apple.com>
>+
>+        AX: macOS VoiceOver doesn't announce when details element is expanded when using role group
>+        https://bugs.webkit.org/show_bug.cgi?id=180866
>+        <rdar://problem/36074338>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/mac/details-summary-expected.txt:
>+        * accessibility/mac/details-summary.html:
>+
> 2018-05-29  Nan Wang  <n_wang@apple.com>
> 
>         AX: setValue on contenteditable should preserve whitespace
>Index: LayoutTests/accessibility/mac/details-summary-expected.txt
>===================================================================
>--- LayoutTests/accessibility/mac/details-summary-expected.txt	(revision 232259)
>+++ LayoutTests/accessibility/mac/details-summary-expected.txt	(working copy)
>@@ -2,6 +2,9 @@ Some open info
> Details about the open topic.
> 
> Some open info
>+Some open info
>+Details about the open topic.
>+
> This tests some basic attributes about the details element.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>@@ -24,6 +27,8 @@ PASS details1.isExpanded is true
> PASS summary1.isExpanded is true
> PASS details2.subrole is 'AXSubrole: AXDetails'
> PASS details2.isExpanded is false
>+PASS details3.subrole is 'AXSubrole: AXApplicationGroup'
>+PASS details3.isExpanded is true
> Received AXExpandedChanged notification 
> Received AXExpandedChanged notification 
> PASS successfullyParsed is true
>Index: LayoutTests/accessibility/mac/details-summary.html
>===================================================================
>--- LayoutTests/accessibility/mac/details-summary.html	(revision 232259)
>+++ LayoutTests/accessibility/mac/details-summary.html	(working copy)
>@@ -15,6 +15,11 @@
>   <p>Details about the open topic.</p>
> </details>
> 
>+<details open id="details3" role="group">
>+  <summary>Some open info</summary>
>+  <p>Details about the open topic.</p>
>+</details>
>+
> <p id="description"></p>
> <div id="console"></div>
> 
>@@ -79,6 +84,11 @@
>         var details2 = accessibilityController.accessibleElementById("details2");
>         shouldBe("details2.subrole", "'AXSubrole: AXDetails'");
>         shouldBeFalse("details2.isExpanded");
>+
>+        // Expanded status should be correct when detail has group role
>+        var details3 = accessibilityController.accessibleElementById("details3");
>+        shouldBe("details3.subrole", "'AXSubrole: AXApplicationGroup'");
>+        shouldBeTrue("details3.isExpanded");
>     }
> 
> </script>

Actions: View | Formatted Diff | Diff

Attachments on bug 180866: 341546