Attachment 341539 Details for Bug 185738 – patch

[patch] patch

a-backup.diff (text/plain), 1.77 KB, created by Saam Barati on 2018-05-29 17:04:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-05-29 17:04:57 PDT

Size: 1.77 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232279)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2018-05-29  Saam Barati  <sbarati@apple.com>
>+
>+        AI for Atomics.load() is too conservative in always clobbering world
>+        https://bugs.webkit.org/show_bug.cgi?id=185738
>+        <rdar://problem/40342214>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It fails the assertion that Fil added for catching disagreements between
>+        AI and clobberize. This patch fixes that. You'd run into this if you
>+        manually enabled SAB in a build and ran any SAB tests.
>+
>+        * dfg/DFGAbstractInterpreterInlines.h:
>+        (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
>+
> 2018-05-29  Saam Barati  <sbarati@apple.com>
> 
>         shrinkFootprint needs to request a full collection
>Index: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h	(revision 232277)
>+++ Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h	(working copy)
>@@ -1815,8 +1815,12 @@ bool AbstractInterpreter<AbstractStateTy
>     case AtomicsStore:
>     case AtomicsSub:
>     case AtomicsXor: {
>-        if (node->op() != GetByVal)
>-            clobberWorld();
>+        if (node->op() != GetByVal) {
>+            unsigned numExtraArgs = numExtraAtomicsArgs(node->op());
>+            Edge storageEdge = m_graph.child(node, 2 + numExtraArgs);
>+            if (!storageEdge)
>+                clobberWorld();
>+        }
>         switch (node->arrayMode().type()) {
>         case Array::SelectUsingPredictions:
>         case Array::Unprofiled:

Actions: View | Formatted Diff | Diff

Attachments on bug 185738: 340614 | 341539