Attachment 341533 Details for Bug 186068 – Patch

[patch] Patch

bug-186068-20180529160227.patch (text/plain), 2.57 KB, created by Alex Christensen on 2018-05-29 16:02:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-05-29 16:02:27 PDT

Size: 2.57 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232276)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-29  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused WebPage::dummy
>+        https://bugs.webkit.org/show_bug.cgi?id=186068
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::dummy): Deleted.
>+        * WebProcess/WebPage/WebPage.h:
>+        * WebProcess/WebPage/WebPage.messages.in:
>+
> 2018-05-25  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Tighten sandbox profiles for Networking Processes to restrict accesses to macOS/iOS Keychains
>Index: Source/WebKit/WebProcess/WebPage/WebPage.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.cpp	(revision 232267)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.cpp	(working copy)
>@@ -730,10 +730,6 @@ WebPage::~WebPage()
> #endif
> }
> 
>-void WebPage::dummy(bool&)
>-{
>-}
>-
> IPC::Connection* WebPage::messageSenderConnection()
> {
>     return WebProcess::singleton().parentProcessConnection();
>Index: Source/WebKit/WebProcess/WebPage/WebPage.h
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.h	(revision 232267)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.h	(working copy)
>@@ -760,10 +760,6 @@ public:
>     bool hasCompositionForTesting();
>     void confirmCompositionForTesting(const String& compositionString);
> 
>-    // FIXME: This a dummy message, to avoid breaking the build for platforms that don't require
>-    // any synchronous messages, and should be removed when <rdar://problem/8775115> is fixed.
>-    void dummy(bool&);
>-
> #if PLATFORM(COCOA)
>     bool isSpeaking();
>     void speak(const String&);
>Index: Source/WebKit/WebProcess/WebPage/WebPage.messages.in
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebPage.messages.in	(revision 232267)
>+++ Source/WebKit/WebProcess/WebPage/WebPage.messages.in	(working copy)
>@@ -357,10 +357,6 @@ messages -> WebPage LegacyReceiver {
>     SetVolumeOfMediaElement(double volume, uint64_t elementID)
> #endif
> 
>-    // FIXME: This a dummy message, to avoid breaking the build for platforms that don't require
>-    // any synchronous messages, and should be removed when <rdar://problem/8775115> is fixed.
>-    Dummy() -> (bool dummyReturn)
>-
>     SetCanRunBeforeUnloadConfirmPanel(bool canRunBeforeUnloadConfirmPanel)
>     SetCanRunModal(bool canRunModal)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186068: 341533