Attachment 341527 Details for Bug 186067 – Patch

[patch] Patch

bug-186067-20180529152303.patch (text/plain), 2.02 KB, created by Jer Noble on 2018-05-29 15:23:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-05-29 15:23:04 PDT

Size: 2.02 KB

patch

obsolete

>Subversion Revision: 232115
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d923930a148a5fbe0635c93b065528b70ab8f4de..96beb55b16ee0ac9539cb7b4f0c17e54b68f89cf 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-29  Jer Noble  <jer.noble@apple.com>
>+
>+        Fix a few issues in WKFullScreenViewController
>+        https://bugs.webkit.org/show_bug.cgi?id=186067
>+        <rdar://problem/40630944>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The check in setInterface() is checking the wrong pointer:
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
>+        (WKFullScreenViewControllerPlaybackSessionModelClient::setInterface):
>+
>+        The check in -_effectiveFullscreenInsetTop is backwards:
>+        (-[WKFullScreenViewController _effectiveFullscreenInsetTop]):
>+
> 2018-05-29  Jer Noble  <jer.noble@apple.com>
> 
>         Auto-pip should use main content heuristic.
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>index 0c7d48db3157374091cdd59ded4f69cc8912a935..f41ced600356f415bffdf06cd98889763596a22b 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>@@ -67,7 +67,7 @@ public:
>             return;
> 
>         if (m_interface && m_interface->playbackSessionModel())
>-            interface->playbackSessionModel()->removeClient(*this);
>+            m_interface->playbackSessionModel()->removeClient(*this);
>         m_interface = interface;
>         if (m_interface && m_interface->playbackSessionModel())
>             interface->playbackSessionModel()->addClient(*this);
>@@ -357,7 +357,7 @@ - (WebFullScreenManagerProxy*)_manager
> @dynamic _effectiveFullscreenInsetTop;
> - (CGFloat)_effectiveFullscreenInsetTop
> {
>-    if (!self.prefersStatusBarHidden)
>+    if (self.prefersStatusBarHidden)
>         return 0;
> 
>     CGRect cancelFrame = _cancelButton.get().frame;

Actions: View | Formatted Diff | Diff

Attachments on bug 186067: 341527