Attachment 341521 Details for Bug 186061 – Patch

[patch] Patch

186061.patch (text/plain), 1.81 KB, created by Michael Saboff on 2018-05-29 14:50:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Saboff

Created: 2018-05-29 14:50:28 PDT

Size: 1.81 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232274)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-05-29  Michael Saboff  <msaboff@apple.com>
>+
>+        REGRESSION(r232212): Broke Win32 Builds
>+        https://bugs.webkit.org/show_bug.cgi?id=186061
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Changed Windows builds with the JIT disabled to generate and use LLIntAssembly.h
>+        instead of LowLevelInterpreterWin.asm.
>+
>+        * CMakeLists.txt:
>+
> 2018-05-29  Caio Lima  <ticaiolima@gmail.com>
> 
>         [ESNext][BigInt] Implement support for "<" and ">" relational operation
>Index: Source/JavaScriptCore/CMakeLists.txt
>===================================================================
>--- Source/JavaScriptCore/CMakeLists.txt	(revision 232263)
>+++ Source/JavaScriptCore/CMakeLists.txt	(working copy)
>@@ -263,7 +263,7 @@ add_dependencies(LLIntOffsetsExtractor J
> # LLIntOffsetsExtractor matches, no output is generated. To make this target consistent and avoid
> # running this command for every build, we artificially update LLIntAssembly.h's mtime (using touch)
> # after every asm.rb run.
>-if (MSVC)
>+if (MSVC AND ENABLE_JIT)
>     set(LLIntOutput LowLevelInterpreterWin.asm)
>     set(OFFLINE_ASM_ARGS --assembler=MASM)
> else ()
>@@ -283,7 +283,7 @@ add_custom_command(
> # the .cpp files below is similar to the one in the previous comment. However, since these .cpp
> # files are used to build JavaScriptCore itself, we can just add LLIntAssembly.h to JSC_HEADERS
> # since it is used in the add_library() call at the end of this file.
>-if (MSVC)
>+if (MSVC AND ENABLE_JIT)
>     enable_language(ASM_MASM)
>     if (CMAKE_SIZEOF_VOID_P EQUAL 4)
>         # Win32 needs /safeseh with assembly, but Win64 does not.

Actions: View | Formatted Diff | Diff

Attachments on bug 186061: 341521