Attachment 341519 Details for Bug 186060 – Patch

[patch] Patch

bug-186060-20180529143933.patch (text/plain), 2.35 KB, created by Chris Dumez on 2018-05-29 14:39:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-29 14:39:33 PDT

Size: 2.35 KB

patch

obsolete

>Subversion Revision: 232274
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 5dcf71d5bd42f373fd0f2c20416434c5e8b66b20..68f2a5607cd72c2285597aadef8fb9bc8cbcb3cb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-05-29  Chris Dumez  <cdumez@apple.com>
>+
>+        Store 0-lifetime stylesheets / scripts into the disk cache for faster history navigations
>+        https://bugs.webkit.org/show_bug.cgi?id=186060
>+        <rdar://problem/40627270>
>+
>+        Reviewed by Geoffrey Garen.
>+
>+        Tweak our storeUnconditionallyForHistoryNavigation logic to match resources whose priority
>+        is High, not just VeryHigh. Per logic in CachedResource::defaultPriorityForResourceType(Type),
>+        This now matches stylesheets and scripts in addition to main resources.
>+
>+        I found that in case of a history navigation to apple.com, a significant number of scripts
>+        and stylesheets had to be loaded from the network because our previous heuristic decided
>+        not to store them (because their priority was not VeryHigh and because their max-age was
>+        0).
>+
>+        * NetworkProcess/cache/NetworkCache.cpp:
>+        (WebKit::NetworkCache::makeStoreDecision):
>+
> 2018-05-28  Jeff Miller  <jeffm@apple.com>
> 
>         Expose additional WKMenuItemIdentifier strings
>diff --git a/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp b/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>index 9cc4a1e1d8b4567c84ab009efa658f6d00b1c14f..c547ea86fcbd5cfc903403d51a77633f56df3425 100644
>--- a/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>+++ b/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>@@ -276,7 +276,7 @@ static StoreDecision makeStoreDecision(const WebCore::ResourceRequest& originalR
>     }
> 
>     bool isMainResource = originalRequest.requester() == WebCore::ResourceRequest::Requester::Main;
>-    bool storeUnconditionallyForHistoryNavigation = isMainResource || originalRequest.priority() == WebCore::ResourceLoadPriority::VeryHigh;
>+    bool storeUnconditionallyForHistoryNavigation = isMainResource || originalRequest.priority() >= WebCore::ResourceLoadPriority::High;
>     if (!storeUnconditionallyForHistoryNavigation) {
>         auto now = WallTime::now();
>         bool hasNonZeroLifetime = !response.cacheControlContainsNoCache() && WebCore::computeFreshnessLifetimeForHTTPFamily(response, now) > 0_ms;

Actions: View | Formatted Diff | Diff

Attachments on bug 186060: 341515 | 341519