Attachment 341494 Details for Bug 186054 – Patch

[patch] Patch

bug-186054-20180529101904.patch (text/plain), 1.62 KB, created by Chris Dumez on 2018-05-29 10:19:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-29 10:19:04 PDT

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 232257
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dbf288615f47ff3483c5c1fab47c560e00fa1089..0294fb162674ca16b2092710ff62401a6bdb143c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-29  Chris Dumez  <cdumez@apple.com>
>+
>+        Avoid unnecessary String allocation in isPublicSuffix(const String&)
>+        https://bugs.webkit.org/show_bug.cgi?id=186054
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Avoid unnecessary String allocation in isPublicSuffix(const String&) by calling directly
>+        the decodeHostName() overload taking in a NSString*. This overload returns a NSString*,
>+        which is what we need. We would previously call the overloading taking in a String, which
>+        would return a String, which we would have to convert back to a NSString*.
>+
>+        * platform/mac/PublicSuffixMac.mm:
>+        (WebCore::isPublicSuffix):
>+
> 2018-05-29  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Miscellaneous fixes to ensure no assertion in LayoutContext::layout
>diff --git a/Source/WebCore/platform/mac/PublicSuffixMac.mm b/Source/WebCore/platform/mac/PublicSuffixMac.mm
>index 6736e2d295bb99865e790e678d4a6e4dbdcf1399..d5891af267f705285e9ff0a3af140433082b7e99 100644
>--- a/Source/WebCore/platform/mac/PublicSuffixMac.mm
>+++ b/Source/WebCore/platform/mac/PublicSuffixMac.mm
>@@ -36,7 +36,7 @@ namespace WebCore {
> 
> bool isPublicSuffix(const String& domain)
> {
>-    NSString *host = decodeHostName(domain);
>+    NSString *host = decodeHostName(static_cast<NSString*>(domain));
>     return host && _CFHostIsDomainTopLevel((CFStringRef)host);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186054: 341494 | 341499