Attachment 341450 Details for Bug 186031 – Patch

[patch] Patch

wcore-anim-crash.diff (text/plain), 1.83 KB, created by Carlos Garcia Campos on 2018-05-28 02:31:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-05-28 02:31:10 PDT

Size: 1.83 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b4a593d2d45..822d8ea31a5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [Web Animations] Test webanimations/css-animations.html is crashing
>+        https://bugs.webkit.org/show_bug.cgi?id=186031
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is another case of std::optional value being used while it's nullopt, I guess this started to fail when we
>+        stopped using the WTF implementation of std::optional. The problem is that we try to get the current iteration
>+        of a declarative animation when the active time is unresolved.
>+
>+        * animation/DeclarativeAnimation.cpp:
>+        (WebCore::DeclarativeAnimation::invalidateDOMEvents): Use value_or(0) instead of value() to get the current
>+        iteration of the effect.
>+
> 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
>diff --git a/Source/WebCore/animation/DeclarativeAnimation.cpp b/Source/WebCore/animation/DeclarativeAnimation.cpp
>index f9e3a9dc1f0..6404aa343e1 100644
>--- a/Source/WebCore/animation/DeclarativeAnimation.cpp
>+++ b/Source/WebCore/animation/DeclarativeAnimation.cpp
>@@ -123,7 +123,7 @@ void DeclarativeAnimation::invalidateDOMEvents(Seconds elapsedTime)
>     auto* animationEffect = effect();
> 
>     auto isPending = pending();
>-    auto iteration = animationEffect ? animationEffect->currentIteration().value() : 0;
>+    auto iteration = animationEffect ? animationEffect->currentIteration().value_or(0) : 0;
>     auto currentPhase = animationEffect ? animationEffect->phase() : phaseWithoutEffect();
> 
>     bool wasActive = m_previousPhase == AnimationEffectReadOnly::Phase::Active;

Actions: View | Formatted Diff | Diff

Attachments on bug 186031: 341450