WebKit Bugzilla
Attachment 341373 Details for
Bug 186006
: [ESNext][BigInt] Skip BigInt div tests breaking on iOS build
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186006-20180525223317.patch (text/plain), 3.90 KB, created by
Caio Lima
on 2018-05-25 18:33:18 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Caio Lima
Created:
2018-05-25 18:33:18 PDT
Size:
3.90 KB
patch
obsolete
>Subversion Revision: 232184 >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 645793478a2711adddb7914f5a4a37b634c4ec0f..7059010623d9680945d2052fbdc20598ecddd447 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,20 @@ >+2018-05-25 Caio Lima <ticaiolima@gmail.com> >+ >+ [ESNext][BigInt] Skip BigInt div tests breaking on iOS build >+ https://bugs.webkit.org/show_bug.cgi?id=186006 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Skippping big-int-div tests on iOS build because they are broken in >+ this architecture. >+ >+ * stress/big-int-div-jit.js: >+ * stress/big-int-div-memory-stress.js: >+ * stress/big-int-div-to-primitive.js: >+ * stress/big-int-div-type-error.js: >+ * stress/big-int-div-wrapped-value.js: >+ * stress/big-int-division.js: >+ > 2018-05-23 Keith Miller <keith_miller@apple.com> > > Define length on CoW array should properly convert to writable >diff --git a/JSTests/stress/big-int-div-jit.js b/JSTests/stress/big-int-div-jit.js >index 0e217e8307e39d4f40c15a2ad0708448266a904f..26e58f8a3edc4f1126a28fdfeac8b1af8c20f031 100644 >--- a/JSTests/stress/big-int-div-jit.js >+++ b/JSTests/stress/big-int-div-jit.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > let assert = { > sameValue: function(i, e, m) { >diff --git a/JSTests/stress/big-int-div-memory-stress.js b/JSTests/stress/big-int-div-memory-stress.js >index 0cf0b9b6faf3ef85c5f59d3ba9bf4a974f73f6f4..d5210333ee40170787474587e82b9120b2d25853 100644 >--- a/JSTests/stress/big-int-div-memory-stress.js >+++ b/JSTests/stress/big-int-div-memory-stress.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > function assert(a) { > if (!a) >diff --git a/JSTests/stress/big-int-div-to-primitive.js b/JSTests/stress/big-int-div-to-primitive.js >index a2973447ea4258262252eafdaae0d62ef1821c88..2d95632ec16d8cdbb140f0ea375fa853fdaf5a2a 100644 >--- a/JSTests/stress/big-int-div-to-primitive.js >+++ b/JSTests/stress/big-int-div-to-primitive.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > function assert(a) { > if (!a) >diff --git a/JSTests/stress/big-int-div-type-error.js b/JSTests/stress/big-int-div-type-error.js >index 27982cd78e030150eafaa4f9346e4f667d5e661b..04eda1651762fcf59c425aa49000dac0aa7aba26 100644 >--- a/JSTests/stress/big-int-div-type-error.js >+++ b/JSTests/stress/big-int-div-type-error.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > function assert(a, message) { > if (!a) >diff --git a/JSTests/stress/big-int-div-wrapped-value.js b/JSTests/stress/big-int-div-wrapped-value.js >index 9bb9aee983af0c0e09758e772384f5eb3c46dc90..1120f8103d8bd4562a6849ab7f5c426c4776c974 100644 >--- a/JSTests/stress/big-int-div-wrapped-value.js >+++ b/JSTests/stress/big-int-div-wrapped-value.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > assert = { > sameValue: function (input, expected, message) { >diff --git a/JSTests/stress/big-int-division.js b/JSTests/stress/big-int-division.js >index 401890ad6316cece7a9b2cad020aab0f5db2991a..e0a6a9478a84cfbfc6dd96fda9ce796cb6beb4aa 100644 >--- a/JSTests/stress/big-int-division.js >+++ b/JSTests/stress/big-int-division.js >@@ -1,4 +1,4 @@ >-//@ runBigIntEnabled >+//@ if $hostOS == "darwin" and $architecture != "x86-64" and $architecture != "x86" then skip else runBigIntEnabled end > > // Copyright (C) 2017 Robin Templeton. All rights reserved. > // This code is governed by the BSD license found in the LICENSE file.
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
ysuzuki
:
review-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186006
: 341373