WebKit Bugzilla
Attachment 341363 Details for
Bug 185526
: [macOS] WebProcess needs TCC entitlements for media capture (Take 2)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185526-20180525171306.patch (text/plain), 18.85 KB, created by
Brent Fulgham
on 2018-05-25 17:13:07 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Brent Fulgham
Created:
2018-05-25 17:13:07 PDT
Size:
18.85 KB
patch
obsolete
>Subversion Revision: 232188 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 4c7331b26dc77653b41a1aa83423742dcb4ed563..94aef6129fdae8d03da1ffeefe984fb238034e00 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,53 @@ >+2018-05-25 Brent Fulgham <bfulgham@apple.com> >+ >+ [macOS] WebProcess needs TCC entitlements for media capture (Take 2) >+ https://bugs.webkit.org/show_bug.cgi?id=185526 >+ <rdar://problem/36674649> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ In Bug 181995 I added TCC entitlements for media capture to the macOS entitlements used for >+ relocatable builds. These changes also need to apply to system builds of WebKit. >+ >+ Previously we had not needed an entitlements file for system builds of WebKit, so only provided >+ an entitlements file for our relocatable build targets. Now we need entitlements when building >+ on recent macOS targets using internal SDKs. >+ >+ When we are not building with internal SDKs, we should revise the sandbox to allow media access >+ so that Open Source developers using public SDK's can build WebKit with media access. >+ >+ Since these various scenarios are beginning to multiple, this patch dynamically generates the >+ entitlements file. >+ >+ This patch does the following: >+ >+ 1. Changes the "WebContent-OSX.entitlements" to hold the TCC entitlements needed for media capture. >+ 2. Removes the unneeded "com.apple.private.xpc.domain-extension" from WebContent-OSX.entitlement, and dynamically >+ adds it using a new build step using the script 'process-webcontent-entitlements.sh' >+ 3. Updates DebugRelease.xcconfig to use the 'Safari Engineering' signing key for internal builds. >+ 4. Updates WebContentService.xcconfig to remove the CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_YES target >+ since we no longer need a custom entitlement file for this case. >+ 5. Updates WebContentService.Development.xcconfig to remove CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO since it is no >+ longer needed. >+ 6. Deletes the file Configurations/WebContent.Development.entitlements since it is no longer needed. >+ 7. Revises the WebContent process sandbox to allow camera and microphone access without needing TCC >+ entitlements, since those cannot be applied without an internal SDK. >+ 8. Revises the UserMediaProcessManager to not pass dynamic sandbox extensions to the WebContent process >+ when building with the public SDK since those entitlements cannot be added or consumed in Open >+ Source builds. >+ >+ We want to use the TCC entitlements when building with the internal SDK on recent macOS builds. >+ >+ * Configurations/WebContent-OSX.entitlements: >+ * Configurations/WebContent.Development.entitlements: Deleted. >+ * Configurations/WebContentService.xcconfig: >+ * Scripts/process-webcontent-entitlements.sh: Added. >+ * UIProcess/UserMediaProcessManager.cpp: >+ (WebKit::UserMediaProcessManager::willCreateMediaStream): Don't bother creating and sending sandbox extensions for >+ camera and microphone control for builds that cannot support them. >+ * WebKit/WebKit.xcodeproj/project.pbxproj: >+ * WebKit/WebProcess/com.apple.WebProcess.sb.in: >+ > 2018-05-25 David Kilzer <ddkilzer@apple.com> > > Fix issues with -dealloc methods found by clang static analyzer >diff --git a/Source/WebKit/Configurations/DebugRelease.xcconfig b/Source/WebKit/Configurations/DebugRelease.xcconfig >index f3eee6dd7696bfdcaf7204043bd8f883e2eafbe4..98de7314c8c811648bdaf1077599c79526518969 100644 >--- a/Source/WebKit/Configurations/DebugRelease.xcconfig >+++ b/Source/WebKit/Configurations/DebugRelease.xcconfig >@@ -43,6 +43,12 @@ SDKROOT = $(SDKROOT_$(USE_INTERNAL_SDK)); > SDKROOT_ = macosx; > SDKROOT_YES = macosx.internal; > >+CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY$(WK_MACOS_1014)_$(USE_INTERNAL_SDK)) >+CODE_SIGN_IDENTITY_BEFORE_1014_YES = -; >+CODE_SIGN_IDENTITY_BEFORE_1014_NO = -; >+CODE_SIGN_IDENTITY_MACOS_SINCE_1014_YES = Safari Engineering; >+CODE_SIGN_IDENTITY_MACOS_SINCE_1014_NO = -; >+ > WK_RELOCATABLE_FRAMEWORKS = YES; > WK_XPC_SERVICE_SUFFIX[sdk=macosx*] = .Development; > WK_XPC_SERVICE_SUFFIX[sdk=*simulator*] = .Development; >diff --git a/Source/WebKit/Configurations/WebContent-OSX.entitlements b/Source/WebKit/Configurations/WebContent-OSX.entitlements >index b492de534916bc944e8a30a4345d6d0bb10793df..2ad5067206a74c1df35151d9ff13b5635cf282a2 100644 >--- a/Source/WebKit/Configurations/WebContent-OSX.entitlements >+++ b/Source/WebKit/Configurations/WebContent-OSX.entitlements >@@ -7,7 +7,5 @@ > <string>kTCCServiceCamera</string> > <string>kTCCServiceMicrophone</string> > </array> >- <key>com.apple.private.xpc.domain-extension</key> >- <true/> > </dict> > </plist> >diff --git a/Source/WebKit/Configurations/WebContent.Development.entitlements b/Source/WebKit/Configurations/WebContent.Development.entitlements >deleted file mode 100644 >index 8cc185af8d78a28646222a3910417f35845727ed..0000000000000000000000000000000000000000 >--- a/Source/WebKit/Configurations/WebContent.Development.entitlements >+++ /dev/null >@@ -1,8 +0,0 @@ >-<?xml version="1.0" encoding="UTF-8"?> >-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> >-<plist version="1.0"> >-<dict> >- <key>com.apple.security.cs.disable-library-validation</key> >- <true/> >-</dict> >-</plist> >diff --git a/Source/WebKit/Configurations/WebContentService.Development.xcconfig b/Source/WebKit/Configurations/WebContentService.Development.xcconfig >index 49d7e1638fb5544ceae9089f73885a3fa128967c..3825c26588eebebf459388fb50bbde1ada888e09 100644 >--- a/Source/WebKit/Configurations/WebContentService.Development.xcconfig >+++ b/Source/WebKit/Configurations/WebContentService.Development.xcconfig >@@ -26,6 +26,4 @@ > SKIP_INSTALL = YES; > SKIP_INSTALL[sdk=macosx*] = $(WK_RELOCATABLE_FRAMEWORKS); > >-CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = Configurations/WebContent.Development.entitlements; >- > WK_XPC_SERVICE_VARIANT = Development; >diff --git a/Source/WebKit/Configurations/WebContentService.xcconfig b/Source/WebKit/Configurations/WebContentService.xcconfig >index 294d419702947ea8495fdeaef0958356e9f92cd1..1602f21d0cba3b16fa1fb5910ee3069ec4d4a8d1 100644 >--- a/Source/WebKit/Configurations/WebContentService.xcconfig >+++ b/Source/WebKit/Configurations/WebContentService.xcconfig >@@ -1,4 +1,4 @@ >-// Copyright (C) 2012-2016 Apple Inc. All rights reserved. >+// Copyright (C) 2012-2018 Apple Inc. All rights reserved. > // > // Redistribution and use in source and binary forms, with or without > // modification, are permitted provided that the following conditions >@@ -33,7 +33,6 @@ WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_appletvsimulator = WebContent-iOS; > WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_iphoneminimalsimulator = WebContent-iOS-minimalsimulator; > > CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = $(CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_$(WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT)); >-CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_YES = Configurations/WebContent-OSX.entitlements; > OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS); > > PRODUCT_NAME = $(PRODUCT_NAME_$(WK_XPC_SERVICE_VARIANT)); >diff --git a/Source/WebKit/Scripts/process-webcontent-entitlements.sh b/Source/WebKit/Scripts/process-webcontent-entitlements.sh >new file mode 100755 >index 0000000000000000000000000000000000000000..ff0a4ad3b484824717afb3ef3ac634031656f1e4 >--- /dev/null >+++ b/Source/WebKit/Scripts/process-webcontent-entitlements.sh >@@ -0,0 +1,32 @@ >+#!/bin/sh >+ >+PROCESSED_XCENT_FILE="${TEMP_FILE_DIR}/${FULL_PRODUCT_NAME}.xcent" >+ >+if [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then >+ echo "Process WebContent process entitlements for app sandbox."; >+ >+ if [[ ${USE_INTERNAL_SDK} == "YES" ]]; then >+ echo "Processing for Internal SDK"; >+ >+ if [[ ${WK_MACOS_1014} == "_MACOS_SINCE_1014" ]]; then >+ echo "Adding TCC entitlements for app sandbox."; >+ /usr/libexec/PlistBuddy -c "Merge Configurations/WebContent-OSX.entitlements" "${PROCESSED_XCENT_FILE}"; >+ fi >+ >+ if [[ ${WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT} == "YES" ]]; then >+ echo "Adding domain extension entitlement for relocatable builds."; >+ /usr/libexec/PlistBuddy -c "Add :com.apple.private.xpc.domain-extension bool YES" "${PROCESSED_XCENT_FILE}"; >+ fi >+ >+ if [[ ${WK_XPC_SERVICE_VARIANT} == "Development" ]]; then >+ echo "Disabling library validation for development build"; >+ /usr/libexec/PlistBuddy -c "Add :com.apple.security.cs.disable-library-validation bool YES" "${PROCESSED_XCENT_FILE}"; >+ fi >+ else >+ echo "Processing for Open Source SDK" >+ fi >+else >+ echo "No additional entitlements needed for non-macOS builds." >+fi >+ >+echo "Completed." >diff --git a/Source/WebKit/UIProcess/UserMediaProcessManager.cpp b/Source/WebKit/UIProcess/UserMediaProcessManager.cpp >index 94a0b4619fd503e83ad1519cec719c3d05499628..ae946f1a90c69ad08d9549b7ccbae30f96a0cc30 100644 >--- a/Source/WebKit/UIProcess/UserMediaProcessManager.cpp >+++ b/Source/WebKit/UIProcess/UserMediaProcessManager.cpp >@@ -128,7 +128,7 @@ void UserMediaProcessManager::muteCaptureMediaStreamsExceptIn(WebPageProxy& page > > bool UserMediaProcessManager::willCreateMediaStream(UserMediaPermissionRequestManagerProxy& proxy, bool withAudio, bool withVideo) > { >-#if ENABLE(SANDBOX_EXTENSIONS) >+#if ENABLE(SANDBOX_EXTENSIONS) && USE(APPLE_INTERNAL_SDK) > auto& processStartingCapture = proxy.page().process(); > > ASSERT(stateMap().contains(&processStartingCapture)); >diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj >index 2ca6e012a2295639b1ae734bfdffbec5f8fa48fb..99f1e0f6946b8316f4a5299aea4d3a8d8394d04d 100644 >--- a/Source/WebKit/WebKit.xcodeproj/project.pbxproj >+++ b/Source/WebKit/WebKit.xcodeproj/project.pbxproj >@@ -1321,6 +1321,8 @@ > 7AAD175F1EA6AF99003B0894 /* WebResourceLoadStatisticsStoreCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7AAD175E1EA6AF37003B0894 /* WebResourceLoadStatisticsStoreCocoa.mm */; }; > 7AB6EA451EEAAE3800037B2B /* APIIconDatabaseClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AB6EA441EEAAE2300037B2B /* APIIconDatabaseClient.h */; }; > 7AB6EA471EEAB6B800037B2B /* APIGeolocationProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AB6EA461EEAB6B000037B2B /* APIGeolocationProvider.h */; }; >+ 7ACFAAD920B88D5000C53203 /* process-webcontent-entitlements.sh in Resources */ = {isa = PBXBuildFile; fileRef = 7ACFAAD820B88D4F00C53203 /* process-webcontent-entitlements.sh */; }; >+ 7ACFAADA20B88D5000C53203 /* process-webcontent-entitlements.sh in Resources */ = {isa = PBXBuildFile; fileRef = 7ACFAAD820B88D4F00C53203 /* process-webcontent-entitlements.sh */; }; > 7AF236201E79A3E400438A05 /* WebErrors.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7AF2361E1E79A3B400438A05 /* WebErrors.cpp */; }; > 7AF236211E79A40800438A05 /* WebErrors.h in Headers */ = {isa = PBXBuildFile; fileRef = 7AF2361F1E79A3D800438A05 /* WebErrors.h */; }; > 7AF236231E79A44400438A05 /* WebErrorsCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7AF236221E79A43100438A05 /* WebErrorsCocoa.mm */; }; >@@ -3190,7 +3192,6 @@ > 37183D55182F4E700080C811 /* WKNSURLExtras.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNSURLExtras.h; sourceTree = "<group>"; }; > 371A193F1824D29300F32A5E /* WKNSDictionary.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKNSDictionary.mm; sourceTree = "<group>"; }; > 371A19401824D29300F32A5E /* WKNSDictionary.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNSDictionary.h; sourceTree = "<group>"; }; >- 37209CAB2079D4BA0009E25B /* WebContent.Development.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = WebContent.Development.entitlements; sourceTree = "<group>"; }; > 372CAF091833FD910040AC27 /* WKNSError.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNSError.h; sourceTree = "<group>"; }; > 372CAF0A1833FD910040AC27 /* WKNSError.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKNSError.mm; sourceTree = "<group>"; }; > 372EBB462017E64300085064 /* com.apple.WebKit.WebContent.Development.xpc */ = {isa = PBXFileReference; explicitFileType = "wrapper.xpc-service"; includeInIndex = 0; path = com.apple.WebKit.WebContent.Development.xpc; sourceTree = BUILT_PRODUCTS_DIR; }; >@@ -3791,6 +3792,7 @@ > 7AAD175E1EA6AF37003B0894 /* WebResourceLoadStatisticsStoreCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebResourceLoadStatisticsStoreCocoa.mm; sourceTree = "<group>"; }; > 7AB6EA441EEAAE2300037B2B /* APIIconDatabaseClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIIconDatabaseClient.h; sourceTree = "<group>"; }; > 7AB6EA461EEAB6B000037B2B /* APIGeolocationProvider.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIGeolocationProvider.h; sourceTree = "<group>"; }; >+ 7ACFAAD820B88D4F00C53203 /* process-webcontent-entitlements.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; path = "process-webcontent-entitlements.sh"; sourceTree = "<group>"; }; > 7AF2361E1E79A3B400438A05 /* WebErrors.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebErrors.cpp; sourceTree = "<group>"; }; > 7AF2361F1E79A3D800438A05 /* WebErrors.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebErrors.h; sourceTree = "<group>"; }; > 7AF236221E79A43100438A05 /* WebErrorsCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebErrorsCocoa.mm; sourceTree = "<group>"; }; >@@ -5059,7 +5061,6 @@ > 1A4F976E100E7B6600637A18 /* Version.xcconfig */, > 7C0BB9A818DCDE890006C086 /* WebContent-iOS.entitlements */, > 37B418EB1C9624F20031E63B /* WebContent-OSX.entitlements */, >- 37209CAB2079D4BA0009E25B /* WebContent.Development.entitlements */, > 372EBB4A2017E76000085064 /* WebContentService.Development.xcconfig */, > BCACC40E16B0B8A800B6E092 /* WebContentService.xcconfig */, > BCB86F4B116AAACD00CE20B7 /* WebKit.xcconfig */, >@@ -8485,6 +8486,7 @@ > 0FC0856F187CE0A900780D86 /* messages.py */, > 0FC08570187CE0A900780D86 /* model.py */, > 0FC08571187CE0A900780D86 /* parser.py */, >+ 7ACFAAD820B88D4F00C53203 /* process-webcontent-entitlements.sh */, > ); > path = Scripts; > sourceTree = "<group>"; >@@ -9850,6 +9852,7 @@ > 372EBB3B2017E64300085064 /* Sources */, > 372EBB3D2017E64300085064 /* Frameworks */, > 372EBB402017E64300085064 /* Resources */, >+ 7AFCBD5520B8917D00F55C9C /* Process WebContent entitlements */, > ); > buildRules = ( > ); >@@ -9943,6 +9946,7 @@ > BC3DE46215A91763008D26FC /* Sources */, > BCDC308D15FDB99A006B6695 /* Frameworks */, > BC3DE46415A91763008D26FC /* Resources */, >+ 7AFCBD5420B8911D00F55C9C /* Process WebContent entitlements */, > ); > buildRules = ( > ); >@@ -10054,6 +10058,7 @@ > isa = PBXResourcesBuildPhase; > buildActionMask = 2147483647; > files = ( >+ 7ACFAADA20B88D5000C53203 /* process-webcontent-entitlements.sh in Resources */, > 372EBB412017E64300085064 /* WebContentProcess.xib in Resources */, > ); > runOnlyForDeploymentPostprocessing = 0; >@@ -10083,6 +10088,7 @@ > isa = PBXResourcesBuildPhase; > buildActionMask = 2147483647; > files = ( >+ 7ACFAAD920B88D5000C53203 /* process-webcontent-entitlements.sh in Resources */, > E1D26A53175964D90095BFD1 /* WebContentProcess.xib in Resources */, > ); > runOnlyForDeploymentPostprocessing = 0; >@@ -10324,6 +10330,44 @@ > shellPath = /bin/sh; > shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-files-in-framework ]; then\n ../../Tools/Scripts/check-for-inappropriate-files-in-framework || exit $?\nfi\n"; > }; >+ 7AFCBD5420B8911D00F55C9C /* Process WebContent entitlements */ = { >+ isa = PBXShellScriptBuildPhase; >+ buildActionMask = 2147483647; >+ files = ( >+ ); >+ inputFileListPaths = ( >+ ); >+ inputPaths = ( >+ "$(TEMP_FILE_DIR)/$(FULL_PRODUCT_NAME).xcent", >+ ); >+ name = "Process WebContent entitlements"; >+ outputFileListPaths = ( >+ ); >+ outputPaths = ( >+ ); >+ runOnlyForDeploymentPostprocessing = 0; >+ shellPath = /bin/sh; >+ shellScript = "Scripts/process-webcontent-entitlements.sh\n"; >+ }; >+ 7AFCBD5520B8917D00F55C9C /* Process WebContent entitlements */ = { >+ isa = PBXShellScriptBuildPhase; >+ buildActionMask = 2147483647; >+ files = ( >+ ); >+ inputFileListPaths = ( >+ ); >+ inputPaths = ( >+ "$(TEMP_FILE_DIR)/$(FULL_PRODUCT_NAME).xcent", >+ ); >+ name = "Process WebContent entitlements"; >+ outputFileListPaths = ( >+ ); >+ outputPaths = ( >+ ); >+ runOnlyForDeploymentPostprocessing = 0; >+ shellPath = /bin/sh; >+ shellScript = "Scripts/process-webcontent-entitlements.sh\n"; >+ }; > 99CA3862207286DB00BAD578 /* Copy WebDriver Atoms to Framework Private Headers */ = { > isa = PBXShellScriptBuildPhase; > buildActionMask = 2147483647; >diff --git a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in >index 24c3aec93f8baa6a19536c81a918ee256831a1a7..336c9f1697978be6dcb18ed73b192cd720148a24 100644 >--- a/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in >+++ b/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in >@@ -795,12 +795,7 @@ > (home-library-preferences-regex (string-append #"/ByHost/" (regex-quote domain) #"\..*\.plist$"))))) > domains)) > >-;; Media capture, microphone access >-(with-filter (extension "com.apple.webkit.microphone") >- (allow device-microphone)) >- >-;; Media capture, camera access >-(with-filter (extension "com.apple.webkit.camera") >+(define (allow-camera) > (shared-preferences-read "com.apple.coremedia") > (allow file-read* (subpath "/Library/CoreMediaIO/Plug-Ins/DAL")) > (allow mach-lookup (extension "com.apple.app-sandbox.mach")) >@@ -817,4 +812,21 @@ > (iokit-user-client-class "IOUSBDeviceUserClientV2") > (iokit-user-client-class "IOUSBInterfaceUserClientV2")) > (allow device-camera)) >+ >+#if USE(APPLE_INTERNAL_SDK) >+;; Media capture, microphone access >+(with-filter (extension "com.apple.webkit.microphone") >+ (allow device-microphone)) >+ >+;; Media capture, camera access >+(with-filter (extension "com.apple.webkit.camera") >+ (allow-camera)) >+#else >+;; Media capture, microphone access >+(allow device-microphone) >+ >+;; Media capture, camera access >+(allow-camera) >+#endif >+ > #endif // PLATFORM(MAC)
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=341363">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185526
:
340118
|
340120
|
340134
|
340645
|
340728
|
341313
|
341363
|
341491
|
341591
|
341617