Attachment 341296 Details for Bug 185985 – Patch

[patch] Patch

bug-185985-20180525094917.patch (text/plain), 1.87 KB, created by Chris Dumez on 2018-05-25 09:49:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-05-25 09:49:18 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 232188
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4c7331b26dc77653b41a1aa83423742dcb4ed563..a5f767ce7cc9fe85895a1f3e3e3225418f7c19bb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-05-25  Chris Dumez  <cdumez@apple.com>
>+
>+        Avoid triggering network cache speculative revalidation for loads allowing expired content
>+        https://bugs.webkit.org/show_bug.cgi?id=185985
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Avoid triggering network cache speculative revalidation for loads allowing expired content
>+        (e.g. history loads, restoring pages after crash or safari relaunch). This causes us to do
>+        unnecessary revalidations, it is both wasteful and bad for performance.
>+
>+        * NetworkProcess/cache/NetworkCache.cpp:
>+        (WebKit::NetworkCache::Cache::retrieve):
>+
> 2018-05-25  David Kilzer  <ddkilzer@apple.com>
> 
>         Fix issues with -dealloc methods found by clang static analyzer
>diff --git a/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp b/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>index e9a9618e41e0c962bb47174d1a48c47ca0dadf51..9cc4a1e1d8b4567c84ab009efa658f6d00b1c14f 100644
>--- a/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>+++ b/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>@@ -321,7 +321,7 @@ void Cache::retrieve(const WebCore::ResourceRequest& request, const GlobalFrameI
>     Key storageKey = makeCacheKey(request);
> 
> #if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
>-    bool canUseSpeculativeRevalidation = m_speculativeLoadManager && !request.isConditional();
>+    bool canUseSpeculativeRevalidation = m_speculativeLoadManager && !request.isConditional() && !cachePolicyAllowsExpired(request.cachePolicy());
>     if (canUseSpeculativeRevalidation)
>         m_speculativeLoadManager->registerLoad(frameID, request, storageKey);
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 185985: 341296