Attachment 341272 Details for Bug 183586 – Patch

[patch] Patch

bug-183586-20180525142722.patch (text/plain), 9.00 KB, created by Rob Buis on 2018-05-25 05:27:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-05-25 05:27:23 PDT

Size: 9.00 KB

patch

obsolete

>Subversion Revision: 232119
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c91c63967200b235101990150cb1b4ec44f9746b..d050eb572839b73bb01238df26dbf837d774445c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,26 @@
>+2018-05-23  Rob Buis  <rbuis@igalia.com>
>+
>+        Custom Elements: connectedCallback is invoked at unexpected timing
>+        https://bugs.webkit.org/show_bug.cgi?id=183586
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When creating an element [1] the steps are different for HTML fragment
>+        parsing and custom elements. Particularly in HTML fragment parsing mode
>+        synchronous custom elements flag should be unset. So in this case [2]
>+        follow step 6.2.
>+
>+        [1] https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
>+        [2] https://dom.spec.whatwg.org/#concept-create-element
>+
>+        Test: imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html
>+
>+        * dom/Element.cpp:
>+        (WebCore::Element::insertedIntoAncestor):
>+        (WebCore::Element::enqueueToUpgrade):
>+        * html/parser/HTMLDocumentParser.cpp:
>+        (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
>+
> 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [GTK] Silence GCC 8 warnings
>diff --git a/Source/WebCore/dom/Element.cpp b/Source/WebCore/dom/Element.cpp
>index 06c4a06302984513da02fdad0b49da7348fb39da..739edab6ad43df06f77444a8353fcd217bfc3cfc 100644
>--- a/Source/WebCore/dom/Element.cpp
>+++ b/Source/WebCore/dom/Element.cpp
>@@ -1977,10 +1977,10 @@ void Element::enqueueToUpgrade(JSCustomElementInterface& elementInterface)
>     InspectorInstrumentation::didChangeCustomElementState(*this);
> 
>     auto& data = ensureElementRareData();
>-    ASSERT(!data.customElementReactionQueue());
>-
>-    data.setCustomElementReactionQueue(std::make_unique<CustomElementReactionQueue>(elementInterface));
>-    data.customElementReactionQueue()->enqueueElementUpgrade(*this);
>+    if (!data.customElementReactionQueue()) {
>+        data.setCustomElementReactionQueue(std::make_unique<CustomElementReactionQueue>(elementInterface));
>+        data.customElementReactionQueue()->enqueueElementUpgrade(*this);
>+    }
> }
> 
> CustomElementReactionQueue* Element::reactionQueue() const
>diff --git a/Source/WebCore/html/parser/HTMLDocumentParser.cpp b/Source/WebCore/html/parser/HTMLDocumentParser.cpp
>index dcf49e9031cf37deb391b85e6d1ba976bfd6aa16..19692d83a9954b955525e7bdf0dcbf9638d4c35b 100644
>--- a/Source/WebCore/html/parser/HTMLDocumentParser.cpp
>+++ b/Source/WebCore/html/parser/HTMLDocumentParser.cpp
>@@ -31,6 +31,7 @@
> #include "DocumentLoader.h"
> #include "Frame.h"
> #include "HTMLDocument.h"
>+#include "HTMLElement.h"
> #include "HTMLParserScheduler.h"
> #include "HTMLPreloadScanner.h"
> #include "HTMLScriptRunner.h"
>@@ -199,8 +200,15 @@ void HTMLDocumentParser::runScriptsForPausedTreeBuilder()
> 
>         // https://html.spec.whatwg.org/#create-an-element-for-the-token
>         auto& elementInterface = constructionData->elementInterface.get();
>-        auto newElement = elementInterface.constructElementWithFallback(*document(), constructionData->name);
>-        m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
>+        if (isParsingFragment()) {
>+            ASSERT(Document::validateCustomElementName(constructionData->name) == CustomElementNameValidationStatus::Valid);
>+            auto newElement = HTMLElement::create(QualifiedName(nullAtom(), constructionData->name, HTMLNames::xhtmlNamespaceURI), *document());
>+            newElement->enqueueToUpgrade(elementInterface);
>+            m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
>+        } else {
>+            auto newElement = elementInterface.constructElementWithFallback(*document(), constructionData->name);
>+            m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
>+        }
>         return;
>     }
> 
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index cd78e6af9ef6dcf3961def9f7fc0a7cefafce1f4..feb5018e65b08dcdcb4c10353fc20b2db84b79f2 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-05-23  Rob Buis  <rbuis@igalia.com>
>+
>+        Custom Elements: connectedCallback is invoked at unexpected timing
>+        https://bugs.webkit.org/show_bug.cgi?id=183586
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html: Added.
>+
> 2018-05-22  Manuel Rego Casasnovas  <rego@igalia.com>
> 
>         [css-text] Import WPT test suite
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..3d43b60c93515c01e6f8213000492bb489a39336
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing-expected.txt
>@@ -0,0 +1,10 @@
>+
>+PASS Inserting a custom element into the document using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into the document of the template elements using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into a new document using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into a cloned document using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into a document created by createHTMLDocument using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into an HTML document created by createDocument using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into the document of an iframe using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+PASS Inserting a custom element into an HTML document fetched by XHR using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor 
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html b/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..890248f5d11a339d3c09a67bd89d45cf2f035469
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html
>@@ -0,0 +1,49 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<title>Custom Elements: the HTML fragment parsing algorithm must not create a custom element synchronously</title>
>+<meta name="author" title="Rob Buis" href="mailto:rbuis@igalia.com">
>+<meta name="assert" content="The HTML fragment parsing algorithm must enqueue a custom element upgrade reaction instead of synchronously invoking its constructor">
>+<link rel="help" href="https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token">
>+<script src="/resources/testharness.js"></script>
>+<script src="/resources/testharnessreport.js"></script>
>+<script src="resources/custom-elements-helpers.js"></script>
>+</head>
>+<body>
>+<div id="log"></div>
>+<script>
>+
>+var iteration = 0;
>+
>+document_types().forEach(function (entry) {
>+    var documentName = entry.name;
>+    var getDocument = entry.create;
>+    let calls = 0;
>+
>+    promise_test(function () {
>+        class Parenter extends HTMLElement {
>+            connectedCallback() {
>+                const child = this.firstChild;
>+                this.removeChild(child);
>+                this.appendChild(child);
>+            }
>+        }
>+        class Child extends HTMLElement {
>+            connectedCallback() { calls++; }
>+        }
>+        iteration++;
>+        let parenter = 'x-parenter' + iteration;
>+        let child = 'x-child' + iteration;
>+        customElements.define(parenter, Parenter);
>+        customElements.define(child, Child);
>+        return getDocument().then(function (doc) {
>+            document.documentElement.innerHTML = `<${parenter}><${child}></${child}></${parenter}>`;
>+            doc.documentElement.appendChild(document.documentElement.firstChild);
>+            assert_equals(calls, 1);
>+        });
>+    }, 'Inserting a custom element into ' + documentName + ' using HTML fragment parsing must enqueue a custom element upgrade reaction, not synchronously invoke its constructor');
>+});
>+
>+</script>
>+</body>
>+</html>

Flags:

rniwa: review-
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 183586: 335672 | 340977 | 340981 | 341004 | 341117 | 341135 | 341186 | 341211 | 341272 | 341278 | 345570 | 345834 | 346614 | 347145 | 357032