Attachment 341269 Details for Bug 185981 – Patch

[patch] Patch

bug-185981-20180525032220.patch (text/plain), 1.88 KB, created by Jeremy Jones on 2018-05-25 03:22:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-05-25 03:22:21 PDT

Size: 1.88 KB

patch

obsolete

>Subversion Revision: 231991
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ef77cb83859a3bc9b332867e0a88dea75276f71a..393f186d8c081026c621308b28dd5b592ba9402f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-25  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Use correct AVKit delegate for picture in picture failure.
>+        https://bugs.webkit.org/show_bug.cgi?id=185981
>+        rdar://problem/40549652
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests since we don't have a way to simulate picture-in-picture failure.
>+
>+        Use the new name for this delegate callback.
>+
>+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
>+        (-[WebAVPlayerViewControllerDelegate playerViewController:failedToStartPictureInPictureWithError:]):
>+        (-[WebAVPlayerViewControllerDelegate playerViewControllerFailedToStartPictureInPicture:withError:]): Deleted.
>+
> 2018-05-18  Jer Noble  <jer.noble@apple.com>
> 
>         Complete fix for enabling modern EME by default
>diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>index 08b86f42c087e98f28811a83243521fe02e3746b..4a11b5c3150f8d59e3d7a6663a34b964014740a3 100644
>--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>@@ -134,7 +134,7 @@ - (void)playerViewControllerDidStartPictureInPicture:(AVPlayerViewController *)p
>     self.fullscreenInterface->didStartPictureInPicture();
> }
> 
>-- (void)playerViewControllerFailedToStartPictureInPicture:(AVPlayerViewController *)playerViewController withError:(NSError *)error
>+- (void)playerViewController:(AVPlayerViewController *)playerViewController failedToStartPictureInPictureWithError:(NSError *)error
> {
>     UNUSED_PARAM(playerViewController);
>     UNUSED_PARAM(error);

Actions: View | Formatted Diff | Diff

Attachments on bug 185981: 341269