Attachment 341252 Details for Bug 185973 – Use #if !ASSERT_DISABLED instead

[patch] Use #if !ASSERT_DISABLED instead

bug-185973-20180524220342.patch (text/plain), 1.91 KB, created by mitz on 2018-05-24 22:03:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: mitz

Created: 2018-05-24 22:03:43 PDT

Size: 1.91 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232183)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-05-24  Dan Bernstein  <mitz@apple.com>
>+
>+        ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives
>+        https://bugs.webkit.org/show_bug.cgi?id=185973
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
>+        (WebKit::ProcessLauncher::launchProcess): Use #if !ASSERT_DISABLED to guard statements that
>+          are only needed for an assertion, instead of #ifndef _NDEBUG, which is always true.
>+
> 2018-05-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK][WPE] Memory pressure monitor doesn't reliable notify all the subprocesses
>Index: Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
>===================================================================
>--- Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm	(revision 232181)
>+++ Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm	(working copy)
>@@ -212,7 +212,7 @@ void ProcessLauncher::launchProcess()
>         if (!processLauncher->isLaunching())
>             return;
> 
>-#ifndef _NDEBUG
>+#if !ASSERT_DISABLED
>         mach_port_urefs_t sendRightCount = 0;
>         mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);
>         ASSERT(sendRightCount >= 1);
>@@ -249,7 +249,7 @@ void ProcessLauncher::launchProcess()
>             ASSERT(xpc_get_type(reply) == XPC_TYPE_DICTIONARY);
>             ASSERT(!strcmp(xpc_dictionary_get_string(reply, "message-name"), "process-finished-launching"));
> 
>-#ifndef _NDEBUG
>+#if !ASSERT_DISABLED
>             mach_port_urefs_t sendRightCount = 0;
>             mach_port_get_refs(mach_task_self(), listeningPort, MACH_PORT_RIGHT_SEND, &sendRightCount);
>             ASSERT(sendRightCount >= 1);

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185973: 341252