Attachment 341240 Details for Bug 185970 – Patch

[patch] Patch

bug-185970-20180525122137.patch (text/plain), 1.94 KB, created by Dean Jackson on 2018-05-24 19:21:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-05-24 19:21:38 PDT

Size: 1.94 KB

patch

obsolete

>Subversion Revision: 232162
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0df47a50d46ba4bff665c7b1be935846e9f277c4..a382d3f0f6bba1ce65fadf19a29f91de7da0c4e0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-24  Dean Jackson  <dino@apple.com>
>+
>+        Need to provide a way to feature detect support for system preview
>+        https://bugs.webkit.org/show_bug.cgi?id=185970
>+        <rdar://problem/40538321>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update the supports function in the DOMTokenList that HTMLAnchorElement
>+        produces for relList to return true for the system preview token.
>+
>+        Tested internally.
>+
>+        * html/HTMLAnchorElement.cpp:
>+        (WebCore::HTMLAnchorElement::relList const):
>+
> 2018-05-24  Chris Dumez  <cdumez@apple.com>
> 
>         Cache navigator.userAgent for performance
>diff --git a/Source/WebCore/html/HTMLAnchorElement.cpp b/Source/WebCore/html/HTMLAnchorElement.cpp
>index c6d57eea394d72d9965030c19b5d6033ad50b4d0..6d256728dade9c5cb74ae757dc7e8c59bfc5d048 100644
>--- a/Source/WebCore/html/HTMLAnchorElement.cpp
>+++ b/Source/WebCore/html/HTMLAnchorElement.cpp
>@@ -313,7 +313,16 @@ DOMTokenList& HTMLAnchorElement::relList() const
> {
>     if (!m_relList) {
>         m_relList = std::make_unique<DOMTokenList>(const_cast<HTMLAnchorElement&>(*this), HTMLNames::relAttr, [](Document&, StringView token) {
>+#if USE(SYSTEM_PREVIEW)
>+#if USE(APPLE_INTERNAL_SDK)
>+            auto systemPreviewRelValue = getSystemPreviewRelValue();
>+#else
>+            auto systemPreviewRelValue = ASCIILiteral("system-preview");
>+#endif
>+            return equalIgnoringASCIICase(token, "noreferrer") || equalIgnoringASCIICase(token, "noopener") || equalIgnoringASCIICase(token, systemPreviewRelValue);
>+#else
>             return equalIgnoringASCIICase(token, "noreferrer") || equalIgnoringASCIICase(token, "noopener");
>+#endif
>         });
>     }
>     return *m_relList;

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 185970: 341240