Attachment 341238 Details for Bug 185741 – Patch

[patch] Patch

bug-185741-20180524181739.patch (text/plain), 1.92 KB, created by Matt Baker on 2018-05-24 18:17:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-05-24 18:17:40 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 232125
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index df2613eade06d61179d9ca3af8133b7c727e8b05..f61b6200708abf710f8b43dca16d2ebf92d941c6 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-05-24  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Popover dismissed while attempting to move cursor inside
>+        https://bugs.webkit.org/show_bug.cgi?id=185741
>+        <rdar://problem/40340938>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Hovering a token within the bounds of the current popover should not
>+        show a new popover. This prevents the popover from being dismissed when
>+        the cursor passes over a token under the transparent portion of the
>+        popover frame.
>+
>+        * UserInterface/Views/SourceCodeTextEditor.js:
>+        (WI.SourceCodeTextEditor.prototype._showPopover):
>+
> 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r232052.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>index 9653b95dbae10989725b69ff0d7daf7ee127f293..7c1ad7bdfead182a1ae93b47ac58ace9a6b2a4b6 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
>@@ -1815,6 +1815,12 @@ WI.SourceCodeTextEditor = class SourceCodeTextEditor extends WI.TextEditor
>             var rects = this.rectsForRange(candidate.hoveredTokenRange);
>             bounds = WI.Rect.unionOfRects(rects);
> 
>+            if (this._popover && this._popover.visible) {
>+                let intersection = bounds.intersectionWithRect(this._popover.frame);
>+                if (intersection.size.width && intersection.size.height)
>+                    return;
>+            }
>+
>             shouldHighlightRange = true;
>         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185741: 340626 | 340627 | 341238 | 341251 | 341291