WebKit Bugzilla
Attachment 341233 Details for
Bug 185966
: [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185966-20180524164455.patch (text/plain), 1.58 KB, created by
Chris Dumez
on 2018-05-24 16:44:56 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2018-05-24 16:44:56 PDT
Size:
1.58 KB
patch
obsolete
>Subversion Revision: 232156 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 13db1a1fd8be620bf4c3a99b91880fddf9762601..13de07a9d2802a25dbdfdceb7c2ae8c29a9e8e8b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-05-24 Chris Dumez <cdumez@apple.com> >+ >+ [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text >+ https://bugs.webkit.org/show_bug.cgi?id=185966 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text >+ for performance reasons. >+ >+ * loader/ios/PreviewLoader.mm: >+ (WebCore::PreviewLoader::shouldCreateForMIMEType): >+ > 2018-05-24 Chris Dumez <cdumez@apple.com> > > Reduce copying of FontCascadeDescription objects by moving them around >diff --git a/Source/WebCore/loader/ios/PreviewLoader.mm b/Source/WebCore/loader/ios/PreviewLoader.mm >index 95334cc2ee01e1015a4b20ce848740fc1735df4a..66c0c9e366b214110b0b6721ba3ebe4098451516 100644 >--- a/Source/WebCore/loader/ios/PreviewLoader.mm >+++ b/Source/WebCore/loader/ios/PreviewLoader.mm >@@ -243,6 +243,9 @@ PreviewLoader::~PreviewLoader() > > bool PreviewLoader::shouldCreateForMIMEType(const String& mimeType) > { >+ if (equalLettersIgnoringASCIICase(mimeType, "text/html") || equalLettersIgnoringASCIICase(mimeType, "text/plain")) >+ return false; >+ > static std::once_flag onceFlag; > static NeverDestroyed<HashSet<String, ASCIICaseInsensitiveHash>> supportedMIMETypes; > std::call_once(onceFlag, [] {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185966
: 341233